From: Andreas Ericsson <exon@op5.com>
To: Jeff King <peff@peff.net>
Cc: Michael Witten <mfwitten@gmail.com>,
demerphq <demerphq@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH RFC 6/6] send-email: Remove horrible mix of tabs and spaces
Date: Wed, 08 Apr 2009 00:10:37 +0200 [thread overview]
Message-ID: <49DBCF5D.6070404@op5.se> (raw)
In-Reply-To: <20090407220048.GB18144@coredump.intra.peff.net>
Jeff King wrote:
> On Tue, Apr 07, 2009 at 04:42:36PM -0500, Michael Witten wrote:
>
>> I'll have to give that a try. However, I've been entertaining the idea
>> of rewriting the whole thing anyway; it's in need of much more than
>> reformatting.
>
> Just my two cents, but if you are considering re-writing send-email, I
> would suggest two things:
>
> 1. Make much heavier use of existing CPAN libraries. A lot of the ugly
> code is trying to handle corner cases in rfc2822 and mime parsing
> and generation. And I would not be surprised if there were still
> bugs in that ugly code.
>
> 2. Make a new command to compete with send-email instead of using the
> same name. This means that people who are really put off by
> CPAN dependencies from (1) above won't be negatively impacted. And
> you can drop any historical interface warts if you want to.
>
3. Make it capable of sending email directly from commits rather than
than having to generate them as files first. For bonus-points, use
git sequencer or some other "git rebase -i"-esque mangling thing
first, with capabilities of adding a cover-letter for patch-series.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
next prev parent reply other threads:[~2009-04-07 22:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 21:25 [PATCH RFC 1/6] send-email: Add --delay for separating emails Michael Witten
2009-04-07 21:25 ` [PATCH RFC 2/6] send-email: --smtp-server-port should take an integer Michael Witten
2009-04-07 21:25 ` [PATCH RFC 3/6] send-email: Handle "GIT:" rather than "GIT: " during --compose Michael Witten
2009-04-07 21:25 ` [PATCH RFC 4/6] send-email: --compose takes optional argument to existing file Michael Witten
2009-04-07 21:25 ` [PATCH RFC 5/6] send-email: Cleanup the usage text a bit Michael Witten
2009-04-07 21:25 ` [PATCH RFC 6/6] send-email: Remove horrible mix of tabs and spaces Michael Witten
2009-04-07 21:35 ` demerphq
2009-04-07 21:42 ` Michael Witten
2009-04-07 21:44 ` demerphq
2009-04-07 21:57 ` demerphq
2009-04-07 22:00 ` Jeff King
2009-04-07 22:10 ` Andreas Ericsson [this message]
2009-04-07 23:33 ` Tomas Carnecky
2009-04-08 2:02 ` Jeff King
2009-04-11 19:22 ` [PATCH RFC 5/6] send-email: Cleanup the usage text a bit Junio C Hamano
2009-04-11 19:22 ` [PATCH RFC 4/6] send-email: --compose takes optional argument to existing file Junio C Hamano
2009-04-11 19:22 ` [PATCH RFC 3/6] send-email: Handle "GIT:" rather than "GIT: " during --compose Junio C Hamano
2009-04-11 20:45 ` Michael Witten
2009-04-12 0:59 ` Junio C Hamano
2009-04-12 2:36 ` Michael Witten
2009-04-07 23:20 ` [PATCH RFC 2/6] send-email: --smtp-server-port should take an integer Junio C Hamano
2009-04-11 19:22 ` Junio C Hamano
2009-04-11 21:01 ` Wesley J. Landaker
2009-04-11 21:07 ` Michael Witten
2009-04-07 21:51 ` [PATCH RFC 1/6] send-email: Add --delay for separating emails Jeff King
2009-04-07 22:08 ` [PATCH RFC 1/6] " Nicolas Sebrecht
2009-04-07 22:17 ` Andreas Ericsson
2009-04-08 6:05 ` Jeff King
2009-04-08 6:03 ` Jeff King
2009-04-07 23:17 ` [PATCH RFC 1/6] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DBCF5D.6070404@op5.se \
--to=exon@op5.com \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=mfwitten@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).