Johannes Schindelin said the following on 13.02.2009 01:08: > There is another reason why I do not want any ReviewingPatches: > reviewing is already such a tedious process; let's not make it > harder by forcing a potential reviewer to sift through a document > (the same could be said about SubmittingPatches; IMHO it just > repeats what common sense would do anyway when imitating existing > code). One thing I've wondered about though when sending patches, is how to send the fixups. Lets say I have a patch serie with 8 patches, do I send the whole serie each time, or do I just send an update to each individual patch? Do I attach it to the previous thread, or start a new one? I couldn't really draw any conclusion by watching the list, since all methods are used. However, I'd like to do what's easiest for the reviewers and maintainers. Probably a new series each time is easiest for Junio to parse and apply, without single updates deep in a thread. However, that might also be considered a tad 'spamming' of the list? Though, ignoring mail threads is fairly trivial with threading MUAs ;-) (I've used "Mark thread as read" quite a bit lately :-) Any opinions, preferably from those that review a lot, and apply patches directly from the mailing list? Maybe this could qualify as a section in Documentation/SubmittingPatches? -- .marius [@trolltech.com] 'if you know what you're doing, it's not research'