From: "Tom G. Christensen" <tgc@statsbiblioteket.dk>
To: Eric Wong <normalperson@yhbt.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] git-svn: fix SVN 1.1.x compatibility
Date: Mon, 19 Jan 2009 10:17:01 +0100 [thread overview]
Message-ID: <4974450D.4090608@statsbiblioteket.dk> (raw)
In-Reply-To: <20090119004556.GA25038@dcvr.yhbt.net>
Eric Wong wrote:
> The get_log() function in the Perl SVN API introduced the limit
> parameter in 1.2.0. However, this got discarded in our SVN::Ra
> compatibility layer when used with SVN 1.1.x. We now emulate
> the limit functionality in older SVN versions by preventing the
> original callback from being called if the given limit has been
> reached. This emulation is less bandwidth efficient, but SVN
> 1.1.x is becoming rarer now.
>
> Additionally, the --limit parameter in svn(1) uses the
> aforementioned get_log() functionality change in SVN 1.2.x.
> t9129 no longer depends on --limit to work and instead uses
> Perl to parse out the commit message.
>
> Thanks to Tom G. Christensen for the bug report.
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
I applied this to 1.6.1 and the testsuite now passes using SVN 1.1.4 on
RHEL 4/i386 (t9106 still fails on RHEL 4/x86_64).
-tgc
next prev parent reply other threads:[~2009-01-19 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 10:11 Minimum required version of subversion for git-svn? Tom G. Christensen
2009-01-12 1:03 ` Eric Wong
2009-01-12 8:03 ` Tom G. Christensen
2009-01-17 10:58 ` Eric Wong
2009-01-19 0:45 ` [PATCH] git-svn: fix SVN 1.1.x compatibility Eric Wong
2009-01-19 9:17 ` Tom G. Christensen [this message]
2009-01-20 1:23 ` Eric Wong
2009-01-20 8:11 ` Tom G. Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4974450D.4090608@statsbiblioteket.dk \
--to=tgc@statsbiblioteket.dk \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).