* [PATCH] Noted that vi is the final choice of editor in git help commit
@ 2009-01-13 22:33 Craig Fratrik
2009-01-14 9:55 ` Adeodato Simó
0 siblings, 1 reply; 3+ messages in thread
From: Craig Fratrik @ 2009-01-13 22:33 UTC (permalink / raw
To: git; +Cc: Craig Fratrik
---
Documentation/git-commit.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
index b5d81be..1b9e7a5 100644
--- a/Documentation/git-commit.txt
+++ b/Documentation/git-commit.txt
@@ -318,8 +318,8 @@ ENVIRONMENT AND CONFIGURATION VARIABLES
---------------------------------------
The editor used to edit the commit log message will be chosen from the
GIT_EDITOR environment variable, the core.editor configuration variable, the
-VISUAL environment variable, or the EDITOR environment variable (in that
-order).
+VISUAL environment variable, the EDITOR environment variable, or finally 'vi'
+(in that order).
HOOKS
-----
--
1.6.0.4.608.ga9645.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Noted that vi is the final choice of editor in git help commit
2009-01-13 22:33 [PATCH] Noted that vi is the final choice of editor in git help commit Craig Fratrik
@ 2009-01-14 9:55 ` Adeodato Simó
2009-01-14 11:14 ` Michael J Gruber
0 siblings, 1 reply; 3+ messages in thread
From: Adeodato Simó @ 2009-01-14 9:55 UTC (permalink / raw
To: Craig Fratrik; +Cc: git
* Craig Fratrik [Tue, 13 Jan 2009 14:33:36 -0800]:
> The editor used to edit the commit log message will be chosen from the
> GIT_EDITOR environment variable, the core.editor configuration variable, the
> -VISUAL environment variable, or the EDITOR environment variable (in that
> -order).
> +VISUAL environment variable, the EDITOR environment variable, or finally 'vi'
> +(in that order).
May I suggest:
The editor used to edit the commit log message will be chosen from the
GIT_EDITOR environment variable, the core.editor configuration variable, the
VISUAL environment variable, or the EDITOR environment variable (in that
-order).
+order). If none of those are set, "vi" will be used.
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
A lie can go round the world before the truth has got its boots on.
-- Terry Pratchett
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Noted that vi is the final choice of editor in git help commit
2009-01-14 9:55 ` Adeodato Simó
@ 2009-01-14 11:14 ` Michael J Gruber
0 siblings, 0 replies; 3+ messages in thread
From: Michael J Gruber @ 2009-01-14 11:14 UTC (permalink / raw
To: Adeodato Simó; +Cc: Craig Fratrik, git
Adeodato Simó venit, vidit, dixit 14.01.2009 10:55:
> * Craig Fratrik [Tue, 13 Jan 2009 14:33:36 -0800]:
>
>> The editor used to edit the commit log message will be chosen from the
>> GIT_EDITOR environment variable, the core.editor configuration variable, the
>> -VISUAL environment variable, or the EDITOR environment variable (in that
>> -order).
>> +VISUAL environment variable, the EDITOR environment variable, or finally 'vi'
>> +(in that order).
>
> May I suggest:
>
> The editor used to edit the commit log message will be chosen from the
> GIT_EDITOR environment variable, the core.editor configuration variable, the
> VISUAL environment variable, or the EDITOR environment variable (in that
> -order).
> +order). If none of those are set, "vi" will be used.
>
+order). If none of those are set, "vi" will be used unless TERM is
+unset or set to "dumb".
There is also some special parsing of the value but I don't think it
needs to be advertised. The terminal-less case, on the other hand, may
be relevant for scripters and ssh'ers.
Cheers,
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-14 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 22:33 [PATCH] Noted that vi is the final choice of editor in git help commit Craig Fratrik
2009-01-14 9:55 ` Adeodato Simó
2009-01-14 11:14 ` Michael J Gruber
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).