git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <derrickstolee@github.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 0/6] minor cleanups to fast-export --anonymize
Date: Fri, 24 Mar 2023 13:40:25 -0400	[thread overview]
Message-ID: <4931e301-2fb6-0d4b-a7bd-f65dee87071a@github.com> (raw)
In-Reply-To: <20230322173636.GA5643@coredump.intra.peff.net>

On 3/22/2023 1:36 PM, Jeff King wrote:
> My goal here was cleaning up some -Wunused-parameter warnings, but doing
> so required a few preparatory cleanups, one of which actually fixes a
> really minor bug (in patch 4).

I saw this was on its way to next(?) without any comment, but it
really doesn't need any. Each patch was clear and created a self-
sufficient reason, but the culmination of dropping parameters and
clearing up memory is also good.

Thanks,
-Stolee

  parent reply	other threads:[~2023-03-24 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 17:36 [PATCH 0/6] minor cleanups to fast-export --anonymize Jeff King
2023-03-22 17:37 ` [PATCH 1/6] fast-export: drop const when storing anonymized values Jeff King
2023-03-22 17:38 ` [PATCH 2/6] fast-export: simplify initialization of anonymized hashmaps Jeff King
2023-03-22 17:40 ` [PATCH 3/6] fast-export: factor out anonymized_entry creation Jeff King
2023-03-22 17:42 ` [PATCH 4/6] fast-export: de-obfuscate --anonymize-map handling Jeff King
2023-03-22 17:42 ` [PATCH 5/6] fast-export: drop data parameter from anonymous generators Jeff King
2023-03-22 17:43 ` [PATCH 6/6] fast-export: drop unused parameter from anonymize_commit_message() Jeff King
2023-03-24 17:40 ` Derrick Stolee [this message]
2023-03-24 19:46   ` [PATCH 0/6] minor cleanups to fast-export --anonymize Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4931e301-2fb6-0d4b-a7bd-f65dee87071a@github.com \
    --to=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).