From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Subject: [RFC PATCH 6/7] t5004: use GNU tar to avoid known issues with BSD tar
Date: Sun, 25 Nov 2018 03:06:49 -0800 [thread overview]
Message-ID: <48f223add200dfcf02f280fcc577cc94255820ce.1543143503.git.carenas@gmail.com> (raw)
In-Reply-To: <cover.1543143503.git.carenas@gmail.com>
56ee96572a ("t5004: resurrect original empty tar archive test", 2013-05-09)
added a test to try to detect and workaround issues with the standard tar
from BSD, but at least in NetBSD would be better to instead require GNU tar
which is available from pkgsrc
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
t/t5004-archive-corner-cases.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/t/t5004-archive-corner-cases.sh b/t/t5004-archive-corner-cases.sh
index ced44355ca..baafc553f8 100755
--- a/t/t5004-archive-corner-cases.sh
+++ b/t/t5004-archive-corner-cases.sh
@@ -31,6 +31,8 @@ test_lazy_prereq UNZIP_ZIP64_SUPPORT '
"$GIT_UNZIP" -v | grep ZIP64_SUPPORT
'
+test $uname_s = NetBSD && TAR="gtar"
+
# bsdtar/libarchive versions before 3.1.3 consider a tar file with a
# global pax header that is not followed by a file record as corrupt.
if "$TAR" tf "$TEST_DIRECTORY"/t5004/empty-with-pax-header.tar >/dev/null 2>&1
--
2.20.0.rc1
next prev parent reply other threads:[~2018-11-25 11:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 11:06 [RFC PATCH 0/7] test: NetBSD support Carlo Marcelo Arenas Belón
2018-11-25 11:06 ` [RFC PATCH 1/7] Documentation: update INSTALL for NetBSD Carlo Marcelo Arenas Belón
2018-11-26 6:27 ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 2/7] t0301: remove trailing / for dir creation Carlo Marcelo Arenas Belón
2018-11-26 6:40 ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 3/7] config.mak.uname: NetBSD uses BSD semantics with fread for directories Carlo Marcelo Arenas Belón
2018-11-26 6:41 ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 4/7] config.mak.uname: NetBSD uses old iconv interface Carlo Marcelo Arenas Belón
2018-11-26 6:45 ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 5/7] test-lib: use pkgsrc provided unzip for NetBSD Carlo Marcelo Arenas Belón
2018-11-26 6:50 ` Junio C Hamano
2018-11-25 11:06 ` Carlo Marcelo Arenas Belón [this message]
2018-11-26 6:52 ` [RFC PATCH 6/7] t5004: use GNU tar to avoid known issues with BSD tar Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 7/7] config.mak.uname: use pkgsrc perl for NetBSD Carlo Marcelo Arenas Belón
2018-11-26 6:53 ` Junio C Hamano
2018-11-26 15:42 ` [RFC PATCH 0/7] test: NetBSD support Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48f223add200dfcf02f280fcc577cc94255820ce.1543143503.git.carenas@gmail.com \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).