From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 7F57B1F8C4 for ; Tue, 29 Mar 2022 03:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231368AbiC2DCl (ORCPT ); Mon, 28 Mar 2022 23:02:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbiC2DCl (ORCPT ); Mon, 28 Mar 2022 23:02:41 -0400 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F10CE1FE55C for ; Mon, 28 Mar 2022 20:00:56 -0700 (PDT) Received: by mail-qv1-xf2a.google.com with SMTP id hu11so13432010qvb.7 for ; Mon, 28 Mar 2022 20:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=cypgQKKvSVRPsSERNxgDx1dZ2/f+oODMts46AyAVWc0=; b=SUFhUJ1RR0HaRjNCUL0ZzVw3Oc20jp8XZrT5ANElh2XUqy94x8gynl9xWAGRStlaCy deQclpI3uPu1Hdxg/36D5tKnG0XRqrdoN0Iyv2+x0lWW23S50BhFCL5t/vQ5TOjuP7Pd 35L13Ldd/FDWAoYRgr4XmOwnpgM43t4QMskwfEVqj4vUMRjzB8JLPkJiJPAvcEQI51BG oi3zc6jE/QiQUexLWkLYoOXJkuUOhfXFUveSVwYnvB/QcdkpEIulIFt7aRvovRlSzl37 xgffF6jo2+HkFyzkZROAzIjeFEjX1xwSos7NN7OO8tKlVsANz5mFoQ1tNIUnbG7Qv0F/ IsFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=cypgQKKvSVRPsSERNxgDx1dZ2/f+oODMts46AyAVWc0=; b=5MJfzJSxkyvxCjKtb7zHJ7Yy9QaiFP1jMUqWetD9AwT/uMeeUFzyidGflfUb7VcUjm wCM8004Z1m3sRZIOXejgWZIuAOtdf4q2IjttxNTgFodhNchuiKQkPZT2Nak0U5pGjDvI xmRUxkpPawdXV4QRTFKho/8bcFvBxyuxTfjCRDS3qCcU1B0RDZZ3+Dhg+xmnC3/UHfVo a6felFpE52SoahW8HWQkYqVIhYxISA95kGpu3D+m5YBxEX+FToPIdn++XPET/xEtEixu PWkjGVwYp+nJqljfNrfCvDUHIulo7zmkbkxAa/V9uDgxrzm8lvvB2Tcz9b7AW1+KhYAB 7DsQ== X-Gm-Message-State: AOAM531fjrZYSO6HNbC2iGO7DjE4rMoc4qt0pcF2WG8mjM0nrTnBEGL3 GrmpDcnGKw2Bmp6pBFo1k6k= X-Google-Smtp-Source: ABdhPJwXuq0iAD8eDGXP7ifD1uub24k7eeub+geFQk5WvEGRhDoHxfmAETIO4efaFjTM6JgA4sGHFQ== X-Received: by 2002:a05:6214:20ef:b0:441:3a9:40d8 with SMTP id 15-20020a05621420ef00b0044103a940d8mr23697402qvk.85.1648522856008; Mon, 28 Mar 2022 20:00:56 -0700 (PDT) Received: from smtpclient.apple ([2601:184:4a7f:100:68a0:55fc:f729:cf38]) by smtp.gmail.com with ESMTPSA id h2-20020ac85842000000b002e1ec550506sm13697299qth.87.2022.03.28.20.00.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 20:00:55 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Desmond Preston Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2 2/2] worktree: accept multiple paths Date: Mon, 28 Mar 2022 23:00:54 -0400 Message-Id: <48242777-6442-4A4D-BE76-1B9EF2F7175B@gmail.com> References: Cc: Des Preston via GitGitGadget , git@vger.kernel.org, Eric Sunshine In-Reply-To: To: Junio C Hamano X-Mailer: iPhone Mail (19D52) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org k.=20 > On Mar 28, 2022, at 9:00 PM, Junio C Hamano wrote: >=20 > =EF=BB=BF"Des Preston via GitGitGadget" writes: >=20 >> From: Des Preston >>=20 >> Update the worktree usage to show that the repair command can take >> multiple paths. >>=20 >> Signed-off-by: Des Preston >> --- >> builtin/worktree.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/builtin/worktree.c b/builtin/worktree.c >> index 8682ff4c417..498975c1fd9 100644 >> --- a/builtin/worktree.c >> +++ b/builtin/worktree.c >> @@ -22,7 +22,7 @@ static const char * const worktree_usage[] =3D { >> N_("git worktree move "), >> N_("git worktree prune []"), >> N_("git worktree remove [] "), >> - N_("git worktree repair []"), >> + N_("git worktree repair [...]"), >=20 > The fact that this line was introduced in [PATCH 1/2] and then > needed to immediately be corrected with this patch means the > previous patch was suboptimal and this patch is "oops, the last one > was bad and here is a band-aid fix-up". >=20 > Let's not do so. Instead, you are encouraged to pretend to be a > more perfect developer who does not make unnecessary mistake ;-) >=20