From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 68C641F45A for ; Fri, 17 Apr 2020 01:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728822AbgDQBxz (ORCPT ); Thu, 16 Apr 2020 21:53:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725800AbgDQBxz (ORCPT ); Thu, 16 Apr 2020 21:53:55 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E536C061A0C for ; Thu, 16 Apr 2020 18:53:55 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id x10so785941oie.1 for ; Thu, 16 Apr 2020 18:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZtXRiwS0Mk0pr8ivmEt/uNVeidBCrcji5EecQ0V4nU4=; b=it+M9ZPLQ6oXqana0IDLsuUuN0attQMMxYJXoFjH1w4WL2wrvTifnPbYumrzrhDkK/ N+bAPOErJogE1fXE0ctxtI6fzhsmnT2A79dP317HkTaYTlWZO3bD7lch8B1prWuUutAw dctjXQIbQv/Z817VBtEgQCQGtFZhVSgNk8mzFivI/XsdjqquIlQ6qb5Bnzb4OcLl2rxH Doo9FlVvEkMy1pqOCSo8ZN1FnEAc7mWI5JYltwGDLsbUo2bhS1DIq4+b0CCxSXv/V7W+ ueBKnVK2xTekTrYRHKRDaQdhYia/Y+h7CNAZqwL3Ta7KXXuXjmLFUWeq1Bq1+8g4iRbC 4rfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZtXRiwS0Mk0pr8ivmEt/uNVeidBCrcji5EecQ0V4nU4=; b=l4RSiHp1gRrZh0kmfe9C5tN8h4eanBbowlReQ/Ub6+1RTT+wLzO2wrZGyj7YH4oJQT zpbXQa0YtV2qKKsmz7THW2fcUVh/vIyNbeW93zFbQI+fEsddc6VW1KmOSRznEE1QLidH 12tF54xQeRrtNqaYiDNPb7InBFgLet2nmXfRlTBNy3S6PEn9qwYRk5lH7JCPTbDJDQfS NaKg7vjOE6D9BWtJdFBHtjtydEF7WD/5wqIpgobA5mX/YuvioHLmMYOamGhiMSpP4i8n SNIwK5CTtSuhG6sUam+Td3+8Q+fOVIszPWId79LYnJ5v8oZneAm/jPDHfogD8qH2eR23 KHnw== X-Gm-Message-State: AGi0PuaZTaP8O1arNBMVPdNwPeUHBZXuhuIk4vFPnmO8aFO/RXPXk9qc 0zNMrsJPbA9zRg7T4m01TsU= X-Google-Smtp-Source: APiQypKuLWkRAt9WN/Ix5tbHksiEs1oP367ieg8JL1y4a05tB7uFAApcL0zNCnwFASMMsefbnJ2pUQ== X-Received: by 2002:aca:1709:: with SMTP id j9mr692494oii.59.1587088434326; Thu, 16 Apr 2020 18:53:54 -0700 (PDT) Received: from [192.168.1.83] ([99.85.27.166]) by smtp.gmail.com with ESMTPSA id d84sm7603092oig.33.2020.04.16.18.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2020 18:53:53 -0700 (PDT) Subject: Re: [PATCH v3 2/2] log: add log.excludeDecoration config option To: Junio C Hamano , Derrick Stolee via GitGitGadget Cc: git@vger.kernel.org, sluongng@gmail.com, me@ttaylorr.com, Derrick Stolee References: <96c865e9214802021f8e991d2194b7aea6cd6bba.1587046549.git.gitgitgadget@gmail.com> From: Derrick Stolee Message-ID: <481d4e05-c6f8-0554-e8f6-04562d316c4c@gmail.com> Date: Thu, 16 Apr 2020 21:53:51 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Thunderbird/76.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 4/16/2020 2:03 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> if (include_patterns && include_patterns->nr) { >>> - int found = 0; >>> for_each_string_list_item(item, include_patterns) { >>> if (match_ref_pattern(refname, item)) { >>> - found = 1; >>> - break; >>> + return 1; >>> } >> >> Micronit. >> >> Let's mimick the early return in the loop above (for command line >> excludes) and below (for configured excludes), each of which is just >> a single "return" statement in a block without {braces} around. > > ... heh, it seems that the nit is mine in the suggested alternative > upthread. Let me amend while queuing. Shame on me for not noticing. Thanks for the close look! -Stolee