From: Derrick Stolee <stolee@gmail.com>
To: Emily Shaffer <emilyshaffer@google.com>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2021, #02; Fri, 8)
Date: Thu, 14 Jan 2021 21:54:44 -0500 [thread overview]
Message-ID: <47b76019-6e58-3f79-e927-c5c6b6e28075@gmail.com> (raw)
In-Reply-To: <15237c6c-98eb-0d1f-e6d5-2dda91c0ce09@gmail.com>
On 1/14/2021 9:36 PM, Derrick Stolee wrote:
> On 1/14/2021 6:06 PM, Emily Shaffer wrote:
>> On Fri, Jan 08, 2021 at 11:22:23AM -0800, Junio C Hamano wrote:
>>> * ds/maintenance-part-4 (2021-01-05) 4 commits
>>> (merged to 'next' on 2021-01-08 at 1f98c859ea)
>>> + maintenance: use Windows scheduled tasks
>>> + maintenance: use launchctl on macOS
>>> + maintenance: include 'cron' details in docs
>>> + maintenance: extract platform-specific scheduling
>>>
>>> Follow-up on the "maintenance part-3" which introduced scheduled
>>> maintenance tasks to support platforms whose native scheduling
>>> methods are not 'cron'.
>>>
>>> Will merge to 'master'.
>>
>> This series again has troubles running inside a directory with regex
>> metachars in the path. Courtesy of Jonathan Nieder, I think this fix
>> matches the intent a little better; but if we don't like this, the same
>> lines could be diffed just to add --fixed-value instead.
...
>>
>> diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh
>> index 2e0c8a4c31..0edad63227 100755
>> --- a/t/t7900-maintenance.sh
>> +++ b/t/t7900-maintenance.sh
>> @@ -487,7 +487,9 @@ test_expect_success 'start and stop macOS maintenance' '
>> GIT_TEST_MAINT_SCHEDULER=launchctl:./print-args git maintenance start &&
>>
>> # start registers the repo
>> - git config --get --global maintenance.repo "$(pwd)" &&
>> + pwd >expect &&
>> + git config --get --global maintenance.repo >actual &&
>> + test_cmp expect actual &&
>
> Sorry again, but this (and others) would probably be better as
>
> + git config --get --global --fixed-value maintenance.repo "$(pwd)" &&
Alternatively, the additional cases of "git config --get --global" in
ds/maintenance-part-4 could actually be simply _removed_ because we
are running all tests on all platforms. We already verify this behavior
in the cron tests, such as 'start from empty cron table'.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-01-15 2:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 19:22 What's cooking in git.git (Jan 2021, #02; Fri, 8) Junio C Hamano
2021-01-09 10:55 ` Ævar Arnfjörð Bjarmason
2021-01-09 21:28 ` Junio C Hamano
2021-01-09 22:05 ` brian m. carlson
2021-01-09 23:20 ` Junio C Hamano
2021-01-11 1:53 ` brian m. carlson
2021-01-11 19:04 ` Junio C Hamano
2021-01-12 14:00 ` Ævar Arnfjörð Bjarmason
2021-01-14 23:52 ` Emily Shaffer
2021-01-14 23:56 ` Emily Shaffer
2021-01-15 7:22 ` Junio C Hamano
2021-01-15 0:29 ` brian m. carlson
2021-01-15 1:44 ` Junio C Hamano
2021-01-16 16:23 ` Ævar Arnfjörð Bjarmason
2021-01-17 17:15 ` Jeff King
2021-01-17 20:22 ` Ævar Arnfjörð Bjarmason
2021-01-10 19:00 ` Ævar Arnfjörð Bjarmason
2021-01-11 0:21 ` Junio C Hamano
2021-01-09 21:38 ` David Aguilar
2021-01-09 23:08 ` Junio C Hamano
2021-01-14 23:06 ` Emily Shaffer
2021-01-15 1:50 ` Junio C Hamano
2021-01-15 2:24 ` Taylor Blau
2021-01-15 2:44 ` Taylor Blau
2021-01-15 2:36 ` Derrick Stolee
2021-01-15 2:54 ` Derrick Stolee [this message]
2021-01-15 6:36 ` Junio C Hamano
2021-01-15 6:38 ` Junio C Hamano
2021-01-15 11:36 ` Derrick Stolee
2021-01-15 19:44 ` Junio C Hamano
2021-01-15 20:08 ` Emily Shaffer
2021-01-15 20:59 ` Junio C Hamano
2021-01-15 19:52 ` Jeff King
2021-01-15 21:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b76019-6e58-3f79-e927-c5c6b6e28075@gmail.com \
--to=stolee@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).