From: Sam Vilain <sam@vilain.net>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-submodule getting submodules from the parent repository
Date: Wed, 02 Apr 2008 12:10:28 +1300 [thread overview]
Message-ID: <47F2C0E4.10506@vilain.net> (raw)
In-Reply-To: <32541b130803301600g5005876enf0fbcfe03e660fc8@mail.gmail.com>
Avery Pennarun wrote:
>> Well, that would create a lot of unnecessary work when cloning.
>> Partitioning by project is a natural way to divide the projects up.
>
> What unnecessary work do you mean?
A full clone takes a few shortcuts, especially over dumb transports like
HTTP. I think there might be shortcuts in the git-daemon code as well.
Forcing these to be partial might make these full fetches involve more
time.
>> However, what you are suggesting should IMHO be allowed to work. In
>> particular, if the submodule path is ".", then I think there's a good
>> case that they should come from within the same project. If it's a
>> relative URL, it should initialize based on the remote URL that was used
>> for the original fetch (or, rather, the remote URL for the current branch).
> I agree, there's no reason to take away the existing functionality of
> allowing split repos. I was more suggesting a new functionality so
> that splitting isn't *required*.
Yes - I look forward to a patch.
>> This push failure thing is regrettable; however it's not clear which
>> branch name the submodules should get. A given commit might exist on
>> several branches, which one do you choose to name it?
> One option is to make a simple "git push origin" operation fail if
> you're not on any branch; iirc, if you try that now, it just silently
> *succeeds* without uploading anything at all, which is one reason I so
> frequently screw it up.
Sounds workable.
> Alternatively, is there a reason I can't
> upload an object *without* giving it a branch name? I guess that
> would cause problems with garbage collection.
You've answered your own question there.
>> There is also a Google Summer of Code project for this - see
>> http://git.or.cz/gitwiki/SoC2008Ideas#head-9215572f23513542a23d3555aa72775bc4b91038
>
> ok. I was hoping it wouldn't be so hard as to require an entire SoC
> project, since using --alternate when checking out the child repo
> shouldn't be too hard.
If you think it is simpler, then I'm sure that submodules users would
appreciate you sharing your ideas as a patch. Sorry if I am starting to
sound like a parrot ;-).
Sam.
next prev parent reply other threads:[~2008-04-01 23:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 22:35 git-submodule getting submodules from the parent repository Avery Pennarun
2008-03-29 23:22 ` Sam Vilain
2008-03-30 13:32 ` Eyvind Bernhardsen
2008-03-30 17:48 ` Sam Vilain
2008-03-30 19:50 ` Eyvind Bernhardsen
2008-03-30 20:19 ` Sam Vilain
2008-03-31 10:05 ` Eyvind Bernhardsen
2008-03-30 23:03 ` Avery Pennarun
2008-03-31 9:29 ` Eyvind Bernhardsen
2008-03-31 21:36 ` Avery Pennarun
2008-04-01 23:05 ` Sam Vilain
2008-04-01 23:56 ` Avery Pennarun
2008-04-02 0:35 ` Junio C Hamano
2008-04-02 2:03 ` Avery Pennarun
2008-04-02 20:06 ` Sam Vilain
2008-04-02 21:32 ` Junio C Hamano
2008-03-30 23:00 ` Avery Pennarun
2008-04-01 23:10 ` Sam Vilain [this message]
2008-03-31 6:22 ` Johannes Sixt
2008-03-31 21:24 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F2C0E4.10506@vilain.net \
--to=sam@vilain.net \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).