git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Brandon Casey <casey@nrlssc.navy.mil>
To: Nicolas Pitre <nico@cam.org>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] builtin-gc.c: allow disabling all auto-gc'ing by assigning 0 to gc.auto
Date: Wed, 19 Mar 2008 16:53:20 -0500	[thread overview]
Message-ID: <47E18B50.2080402@nrlssc.navy.mil> (raw)
In-Reply-To: <47E18540.4020908@nrlssc.navy.mil>

The gc.auto configuration variable is somewhat ambiguous now that there
is also a gc.autopacklimit setting. Some users may assume that it controls
all auto-gc'ing. Also, now users must set two configuration variables to
zero when they want to disable autopacking. Since it is unlikely that users
will want to autopack based on some threshold of pack files when they have
disabled autopacking based on the number of loose objects, be nice and allow
a setting of zero for gc.auto to disable all autopacking.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 builtin-gc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/builtin-gc.c b/builtin-gc.c
index 95917d7..509bb9c 100644
--- a/builtin-gc.c
+++ b/builtin-gc.c
@@ -160,10 +160,10 @@ static int too_many_packs(void)
 static int need_to_gc(void)
 {
 	/*
-	 * Setting gc.auto and gc.autopacklimit to 0 or negative can
-	 * disable the automatic gc.
+	 * Setting gc.auto to 0 or negative can disable the
+	 * automatic gc.
 	 */
-	if (gc_auto_threshold <= 0 && gc_auto_pack_limit <= 0)
+	if (gc_auto_threshold <= 0)
 		return 0;
 
 	/*
-- 
1.5.4.4.481.g5075

  reply	other threads:[~2008-03-19 21:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 18:01 auto gc again Jens Axboe
2008-03-18 18:14 ` Linus Torvalds
2008-03-18 18:19   ` Jens Axboe
2008-03-18 18:24     ` Jens Axboe
2008-03-18 18:33       ` Linus Torvalds
2008-03-18 18:39         ` Jens Axboe
2008-03-19 20:22           ` Johannes Schindelin
2008-03-19 21:14             ` Jens Axboe
2008-03-19 21:44               ` Johannes Schindelin
2008-03-20  6:00                 ` Jens Axboe
2008-03-19 20:37     ` Nicolas Pitre
2008-03-19 21:17       ` Jens Axboe
2008-03-19 23:05         ` Nicolas Pitre
2008-03-20  7:40           ` Jens Axboe
2008-03-20  7:55             ` Junio C Hamano
2008-03-20 17:31               ` Jens Axboe
2008-03-19 21:27       ` Brandon Casey
2008-03-19 21:53         ` Brandon Casey [this message]
2008-03-20  7:08           ` [PATCH] builtin-gc.c: allow disabling all auto-gc'ing by assigning 0 to gc.auto Teemu Likonen
2008-03-19 22:56         ` auto gc again Nicolas Pitre
2008-03-20  6:01         ` Jens Axboe
2008-03-19 21:27 ` Junio C Hamano
2008-03-19 21:52   ` Linus Torvalds
2008-03-19 22:28     ` Junio C Hamano
2008-03-19 23:16       ` Nicolas Pitre
2008-03-19 23:25         ` Junio C Hamano
2008-03-20  3:13           ` Nicolas Pitre
2008-03-20  4:09             ` Junio C Hamano
2008-03-20  4:40               ` Nicolas Pitre
2008-03-20  4:49                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E18B50.2080402@nrlssc.navy.mil \
    --to=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jens.axboe@oracle.com \
    --cc=nico@cam.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).