From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 249421F66F for ; Thu, 29 Oct 2020 01:32:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729658AbgJ2Bap (ORCPT ); Wed, 28 Oct 2020 21:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbgJ2B3N (ORCPT ); Wed, 28 Oct 2020 21:29:13 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A137C0613CF for ; Wed, 28 Oct 2020 18:29:13 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id p15so1700976ioh.0 for ; Wed, 28 Oct 2020 18:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1qKFFrlsdgMXeD6JRHR6f/xVn1rRaLtfgowyoWU6bAY=; b=VxuqJhAeVTpjMLU1pZwaJ5QT/pEeINQepddVungEpuRf44p4wanosnoZeFivc8dfUc bkng7wTyOILfCfY+DaVMy6sNxqJ03+QwdsE0j6YOSxSabLJwUlULrf8Y4VFqXcRkkre0 F0WtUbDtUjhAvQu0GclMVvn4Z8KAqj9N0Ak9TBRLlUC40HfrliyqoeIW7mvi/xOYu8bU kEhytqpREKpjw6CO058P+pB6bUGCKiAsFthgnjy7lEsxHB9E5Uk88brDJ20tbFFO7KcU HncwMIBevp/is9K4lJjQiXJnxOiTjvU4MFHCaBVQtLaHg6ikzaKEfKmyOn619lj+9zF0 8Mcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1qKFFrlsdgMXeD6JRHR6f/xVn1rRaLtfgowyoWU6bAY=; b=aHiQjxIEUzTV56Qw1vG7mzb+fgWOwxmXYCL3w5BPN/jxbK6K6nFj9Eil248OtJ2zPJ xV8ktKJ2wlbzL8e77VlkXYKvwoKQszqBFVPbobNfuHKyoW2MOAkWqPfrOpEb3i7bc/mf Z9TLjluWW0pWveaL6Z/qZmnfLVibV2hgGUXtchlMjn/UAl2Q5dpnJnkPVSENBIAh+1wW J/ejZuDU6d8hoUhdLo/snMwgqJ/GiJSR4zmdwRr+HkP12q0gHY4NaRKR0ZyFgrxdl5qG lc20EhAFW12lpliJyhFsx0cFkT7yhSKz6C3ZcbIXKBQDQ2+rFqmMBqTtmzRcpA22gzHk eJtQ== X-Gm-Message-State: AOAM532Jyn62lLOahwwLRkgOSe5NBL5nWtjtxvq8JyuRouonz/UlqORU EBf91EGDLGKbL0G8FSFbWUo= X-Google-Smtp-Source: ABdhPJx1t+mrxZFpgr25xRUcwUjFNWV/WoN9K95MN+zshLlfUUG6Wuqh1CvXQZ8qDKj0x2Uhnga6Pw== X-Received: by 2002:a02:7348:: with SMTP id a8mr1655273jae.76.1603934952470; Wed, 28 Oct 2020 18:29:12 -0700 (PDT) Received: from [192.168.1.127] ([192.222.216.4]) by smtp.gmail.com with ESMTPSA id z9sm951951ilm.21.2020.10.28.18.29.10 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 28 Oct 2020 18:29:11 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v4 1/2] ref-filter: handle CRLF at end-of-line more gracefully From: Philippe Blain In-Reply-To: Date: Wed, 28 Oct 2020 21:29:07 -0400 Cc: Philippe Blain via GitGitGadget , Git mailing list , Michael J Gruber , Matthieu Moy , John Keeping , Karthik Nayak , Jeff King , Alex Henrie , Eric Sunshine Content-Transfer-Encoding: quoted-printable Message-Id: <47BFCD45-B3C2-4AF6-BE09-DA5E1BFAF5E6@gmail.com> References: <03b2d7d78a15d15130a68ed1e6092072aa0807cd.1603335680.git.gitgitgadget@gmail.com> To: Junio C Hamano X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Junio, > Le 28 oct. 2020 =C3=A0 16:24, Junio C Hamano a = =C3=A9crit : >=20 > Philippe Blain writes: >=20 >>> Having said all that. >>>=20 >>> Here is how I explained the topic in the "What's cooking" report. >>>=20 >>> A commit and tag object may have CR at the end of each and >>> every line (you can create such an object with hash-object or >>> using --cleanup=3Dverbatim to decline the default clean-up >>> action), but it would make it impossible to have a blank line >>> to separate the title from the body of the message. Be lenient >>> and accept a line with lone CR on it as a blank line, too. >>=20 >> Just for the sake of searchability, I think it would be good to have=20= >> CRLF spelled out in this topic description (since I gather this is = what=20 >> ends up in the release notes). But I don't feel that strongly >> about that. >>=20 >>> Let's not call this change a "bug fix". The phrase you used in your >>> title, "more gracefully", is a very good one. >>=20 >> It was your suggestion ;)=20 >>=20 >>> In the meantime, I've squashed your "oops forgot ||return 1" change >>> into [PATCH 2/2]. >>=20 >> Thanks for squashing it in. >=20 > Squashing in the "oops forgot || return 1" was the only thing I did. > I did not rewrite (and will not do so myself) the proposed log > message 1/2, which needs to happen before the topic can hit 'next'. Ah! I thought you meant "Let's not call it a bug fix in the release = notes". I'll send a new version to not mention "bug" in the log messages. Thanks, Philippe.=