From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 3E2D51F4B4 for ; Tue, 6 Apr 2021 11:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242115AbhDFLq3 (ORCPT ); Tue, 6 Apr 2021 07:46:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238146AbhDFLq1 (ORCPT ); Tue, 6 Apr 2021 07:46:27 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D11DC061756 for ; Tue, 6 Apr 2021 04:46:19 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id x207so14781923oif.1 for ; Tue, 06 Apr 2021 04:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YKnT1yHqY80zVrrspE8SH9jPpvlBc1tA44t3r86dKQo=; b=Scc67XkxnkEprvCzj/7hQ9gdsYKqAexrgMeFs6+YwW0PchSq+M63p05432AnSF5VNk 32frNqEB4Uhmeu5NAc7kPsjlAXjscMqCM+i+Mxey29TgMb2aVaCKqNwLv0Bqc4yu8Dvr ieF5AYu2NtadOcAbJhULylbS3mXoGeifADTZNmsdLicDlgvc4gGbPyCC4JKJr1qmabRG 8T1sT8iomz3Fm/s2tpSOd1aElcSPjFcIqNV3OSVQaItNGUApFksjhbXlgZDFueM6gENu cNOQaeWGdi4bl7cE36s4w2BYQrNcYkB+x5VVCRHJDy2/Q80b1vysi7DjondFGnAeL6gx 0Trw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YKnT1yHqY80zVrrspE8SH9jPpvlBc1tA44t3r86dKQo=; b=PPItuRhrG+D4fMUtDLwQtrHAOB6UXCAyQiYL2R6UkUUgZ9NdxSzuUsbyJZeTVeiwju CNuyuju2F0kBF4SPpc3MG/XS17/994f3jEh/mEAanE0cT0ISPSUsHsSZ1/NQ1oPAZpfH rUw+ar1Pz8IldIHIGu5hPwINL9/Ob8ZlUbsn3QUhbGua0Z2oU3+1aXC488pCRGJdAGSk uoPjDdjbIIXnCCnQCucb/f4d9V6zaZsGQTpN/j5rHyH7ExLiPwGvXuWS7D44Tm2wfOCE BuuoAnEjmsqOZagtF45pvao0I0dwZEUZc4jo7FgvTLzu/ApbyIItgd3niRffrFH5nwK7 jmqQ== X-Gm-Message-State: AOAM533AyjJl8KeSah4YyYu1XaK6j1qkXbO9LLe4+ll+yCPPwE6z5U4c AHgPBQBXxW3u82jjeNc/+SI= X-Google-Smtp-Source: ABdhPJwatgYXqyoEFpLcKvTalUms6hgA+86TTeij9UcWIc/2JYsnJkWlZMEyoRy9Rvqq3/pmlP2NyA== X-Received: by 2002:a05:6808:68e:: with SMTP id k14mr2894988oig.175.1617709578762; Tue, 06 Apr 2021 04:46:18 -0700 (PDT) Received: from ?IPv6:2600:1700:e72:80a0:7d35:99dc:7770:379a? ([2600:1700:e72:80a0:7d35:99dc:7770:379a]) by smtp.gmail.com with ESMTPSA id p3sm4636838otk.9.2021.04.06.04.46.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 04:46:18 -0700 (PDT) Subject: Re: [PATCH v2 24/25] sparse-index: expand_to_path() To: Elijah Newren , Derrick Stolee via GitGitGadget Cc: Git Mailing List , Junio C Hamano , Matheus Tavares Bernardino , Derrick Stolee , Derrick Stolee References: From: Derrick Stolee Message-ID: <4768fac6-1d8d-4865-76a2-19f110f66219@gmail.com> Date: Tue, 6 Apr 2021 07:46:17 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 4/5/2021 3:32 PM, Elijah Newren wrote: > On Wed, Mar 31, 2021 at 6:50 PM Derrick Stolee via GitGitGadget > wrote: >> >> From: Derrick Stolee >> + if (index_file_exists(istate, path_mutable.buf, >> + path_mutable.len, icase)) { >> + /* >> + * We found a parent directory in the name-hash >> + * hashtable, which means that this entry could >> + * exist within a sparse-directory entry. Expand >> + * accordingly. > > "this entry" is a bit unclear; it might be worth referring to the > "path" variable instead. I think it'd also help to explain the > reasoning for using the '/' character, because while it's clear when > looking at the series, just running across it in the code it might be > easy to forget or miss. Perhaps: > > * We found a parent directory in the name-hash > * hashtable, because only sparse directory entries > * have a trailing '/' character. Since "path" wasn't > * in the index, perhaps it exists within this > * sparse-directory. Expand accordingly. A good recommendation. Thanks. -Stolee