From: Andreas Ericsson <ae@op5.se>
To: Michael Witten <mfwitten@MIT.EDU>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: On Tabs and Spaces
Date: Tue, 16 Oct 2007 19:20:10 +0200 [thread overview]
Message-ID: <4714F2CA.5000509@op5.se> (raw)
In-Reply-To: <11F85069-1013-4685-9D56-C53F0F8231BF@MIT.EDU>
Michael Witten wrote:
> On 16 Oct 2007, at 3:04:21 AM, Shawn O. Pearce wrote:
>
>> The C code is all tabs, with the tabs set at 8 spaces, but the
>> actual tab width isn't too important here as we never use the tab
>> for alignment beyond the left indent.
>
> Consider this from diff-lib.c:
>
>> /* A file entry went away or appeared */
>> static void diff_index_show_file(struct rev_info *revs,
>> const char *prefix,
>> struct cache_entry *ce,
>> unsigned char *sha1, unsigned int mode)
>> {
>> diff_addremove(&revs->diffopt, prefix[0], ntohl(mode),
>> sha1, ce->name, NULL);
>> }
>
> There are mixed tabs and spaces for alignment.
>
Function declarations don't count ;-)
> I suppose I'll be fine if I just set tab widths to 8.
> But 8 spaces! Good Lord. ;-)
>
> I really hate tabs.
>
Well, using hard tabs is the only way we can let everyone have
different levels of indentation while still having things look
sort of sane.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2007-10-16 17:20 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 6:45 On Tabs and Spaces Michael Witten
2007-10-16 7:04 ` Shawn O. Pearce
2007-10-16 7:27 ` Michael Witten
2007-10-16 17:20 ` Andreas Ericsson [this message]
2007-10-16 17:40 ` Sam Ravnborg
2007-10-16 23:09 ` Petr Baudis
2007-10-17 3:41 ` David
2007-10-17 11:32 ` Andy Parkins
2007-10-16 8:30 ` Adam Piatyszek
2007-10-16 9:04 ` Lars Hjemli
2007-10-16 10:16 ` Adam Piatyszek
2007-10-16 15:26 ` Jeffrey C. Ollie
2007-10-16 15:51 ` Michael Witten
2007-10-16 17:06 ` Jari Aalto
2007-10-16 19:20 ` Linus Torvalds
2007-10-16 19:36 ` Mike Hommey
2007-10-16 19:47 ` Linus Torvalds
2007-10-16 19:51 ` Linus Torvalds
2007-10-16 20:32 ` Matthieu Moy
2007-10-16 20:18 ` Tom Tobin
2007-10-16 23:05 ` Linus Torvalds
2007-10-16 23:51 ` Christer Weinigel
2007-10-17 0:45 ` Linus Torvalds
2007-10-17 3:08 ` Michael Witten
2007-10-17 3:29 ` Linus Torvalds
2007-10-17 7:17 ` Luke Lu
2007-10-17 9:09 ` Michael Witten
2007-10-17 10:03 ` Luke Lu
2007-10-17 10:21 ` Nikolai Weibull
2007-10-17 11:23 ` Michael Witten
2007-10-17 22:02 ` Jari Aalto
2007-10-17 22:36 ` Andreas Ericsson
2007-10-17 23:38 ` Jari Aalto
2007-10-18 4:31 ` Dmitry Torokhov
2007-10-18 8:19 ` Jari Aalto
2007-10-18 11:34 ` Petr Baudis
2007-10-18 11:39 ` Nikolai Weibull
2007-10-22 3:39 ` Miles Bader
2007-10-18 7:15 ` David Kågedal
2007-10-18 5:42 ` Mike Hommey
2007-10-18 10:36 ` Jari Aalto
2007-10-17 15:53 ` Linus Torvalds
2007-10-17 18:05 ` Johannes Schindelin
2007-10-17 18:25 ` Tom Tobin
2007-10-17 18:54 ` Linus Torvalds
2007-10-17 19:33 ` Tom Tobin
2007-10-17 19:44 ` Linus Torvalds
2007-10-17 19:48 ` Nicolas Pitre
2007-10-17 19:52 ` Josh England
2007-10-17 19:53 ` Linus Torvalds
2007-10-17 21:21 ` Christer Weinigel
2007-10-17 22:03 ` Linus Torvalds
2007-10-18 6:25 ` David Kastrup
2007-10-17 22:11 ` Johannes Schindelin
2007-10-17 23:17 ` Christer Weinigel
2007-10-17 23:44 ` Johannes Schindelin
2007-10-18 0:31 ` Christer Weinigel
2007-10-18 6:02 ` Andreas Ericsson
2007-10-18 7:12 ` David Kågedal
2007-10-17 23:53 ` Linus Torvalds
2007-10-17 20:31 ` David Kastrup
2007-10-17 21:08 ` Johannes Schindelin
2007-10-17 19:47 ` Jan Wielemaker
2007-10-18 0:32 ` Jeff King
2007-10-18 0:59 ` Linus Torvalds
2007-10-18 2:45 ` Jeff King
2007-10-18 3:03 ` david
2007-10-18 3:00 ` Jeff King
2007-10-18 3:32 ` Linus Torvalds
2007-10-18 4:17 ` Linus Torvalds
2007-10-18 3:13 ` Linus Torvalds
2007-10-18 3:23 ` Jeff King
2007-10-18 4:41 ` [PATCH] Add a message explaining that automatic GC is about to start koreth
2007-10-18 4:44 ` Steven Grimm
2007-10-18 5:01 ` Jeff King
2007-10-18 5:11 ` Shawn O. Pearce
2007-10-18 13:52 ` Brian Gernhardt
2007-10-18 14:16 ` Steven Grimm
2007-10-18 18:08 ` Jeff King
2007-10-19 0:16 ` Shawn O. Pearce
2007-10-19 1:12 ` [PATCH] git-gc: improve wording of --auto notification Jeff King
2007-10-19 1:24 ` Shawn O. Pearce
2007-10-19 1:26 ` Jeff King
2007-10-18 14:21 ` [PATCH] Add a message explaining that automatic GC is about to start Nicolas Pitre
2007-10-18 4:52 ` On Tabs and Spaces Nicolas Pitre
2007-10-18 4:54 ` Jeff King
2007-10-18 4:55 ` Jeff King
2007-10-17 16:08 ` David Kastrup
2007-10-17 17:44 ` Nicolas Pitre
2007-10-17 19:52 ` David Kastrup
2007-10-17 17:51 ` Sean
2007-10-17 5:56 ` David Kastrup
2007-10-16 20:56 ` Sam Ravnborg
2007-10-18 3:31 ` Paul Wankadia
2007-10-18 4:22 ` Linus Torvalds
2007-10-18 4:36 ` Dmitry Potapov
2007-10-16 17:23 ` Andreas Ericsson
2007-10-16 18:34 ` Jan-Benedict Glaw
2007-10-16 18:51 ` Andreas Ericsson
2007-10-20 13:54 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4714F2CA.5000509@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=mfwitten@MIT.EDU \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).