From: "Ping Yin" <pkufranky@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone
Date: Tue, 22 Apr 2008 17:09:10 +0800 [thread overview]
Message-ID: <46dff0320804220209n590a0684x876270c7b1c0c2d@mail.gmail.com> (raw)
In-Reply-To: <7v3ape2ufs.fsf@gitster.siamese.dyndns.org>
On Tue, Apr 22, 2008 at 3:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
> "Ping Yin" <pkufranky@gmail.com> writes:
>
>
> > I just want to unify the behaviour of handling relative url.
> >
> > 'git submodule add' treats './foo' and 'foo' as different urls. The
> > 1st one is relative to remote.origin.url, while the 2nd one is
> > relative the current directory. I think this kind of behaviour is
> > better for submodules, so i unify the handling of relative urls as
> > this.
> >
> > With this kind of behaviour, i can set 'submodule.foo.url=./foo' in
> > .gitmodules or $GIT_DIR/config. And when remote.origin.url changes, i
> > have not to change submodule.foo.url if the super project and
> > submodule foo are always located on the same central host.
>
> Please have that kind of justification in the proposed commit log message.
> When these changes are made into history, people cannot ask you questions
> like I did and expect the history to produce such answer on demand ;-)
>
OK, i'll resend this patch tonight.
--
Ping Yin
next prev parent reply other threads:[~2008-04-22 9:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 14:19 [PATCH 0/7] submodule: fallback to .gitmodules and multiple level module definition Ping Yin
2008-04-16 14:19 ` [PATCH 1/7] git-submodule: Extract functions module_info and module_url Ping Yin
2008-04-16 14:19 ` [PATCH 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone Ping Yin
2008-04-16 14:19 ` [PATCH 3/7] git-submodule: Fall back on .gitmodules if info not found in $GIT_DIR/config Ping Yin
2008-04-16 14:19 ` [PATCH 4/7] git-submodule: Extract module_add from cmd_add Ping Yin
2008-04-16 14:19 ` [PATCH 5/7] git-submodule: multi-level module definition Ping Yin
2008-04-16 14:19 ` [PATCH 6/7] git-submodule: "update --force" to enforce cloning non-submodule Ping Yin
2008-04-16 14:19 ` [PATCH 7/7] git-submodule: Don't die when command fails for one submodule Ping Yin
2008-04-22 6:10 ` [PATCH 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone Junio C Hamano
2008-04-22 6:50 ` Ping Yin
2008-04-22 7:57 ` Junio C Hamano
2008-04-22 9:09 ` Ping Yin [this message]
2008-04-22 14:38 ` Ping Yin
2008-04-22 14:41 ` Ping Yin
[not found] ` <alpine.DEB.1.00.0804221609200.4460@eeepc-johanness>
2008-04-22 16:54 ` Ping Yin
2008-04-22 17:13 ` Jakub Narebski
2008-04-22 17:20 ` Ping Yin
2008-04-22 7:00 ` Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dff0320804220209n590a0684x876270c7b1c0c2d@mail.gmail.com \
--to=pkufranky@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).