From: "Ping Yin" <pkufranky@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] git-submodule: New subcommand 'summary' (3) - limit summary size
Date: Sat, 1 Mar 2008 18:29:26 +0800 [thread overview]
Message-ID: <46dff0320803010229h17b810a7k26d0ac36cf1eaef6@mail.gmail.com> (raw)
In-Reply-To: <46dff0320803010216m1bd20674if82d2d2072858290@mail.gmail.com>
On Sat, Mar 1, 2008 at 3:29 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Ping Yin <pkufranky@gmail.com> writes:
>
> > This patches teaches git-submodule an option '--summary-limit|-n <number>'
> > to limit number of commits for the summary. Number 0 will disable summary
> > and minus number will not limit the summary size.
>
> "Negative means unlimited" feels unnecessary. Didn't you make "unlimited"
> the default anyway?
'unlimited' is the default, i should clarify this in the message.
I think 'Negative means unlimited' is neccessary. Someone may override
--summary-limit in the shell alias, but sometime he may want to bring
back the unlimited behavior in the command line.
> >
> > For beauty and clarification, the last commit for each section (backward
> > and forward) will always be shown disregarding the given limit. So actual
> > summary size may be greater than the given limit.
> >
> > In the same super project of these patch series, 'git submodule -n 2
> > summary sm1' and 'git submodule -n 3 summary sm1' will show the same.
>
> This description is unclear. Does "-n 2" tell "show 2 commits from both
> side", or "show 2 in total"?
>
I should make it clear that -n means 'in total'.
>
> > ---------------------------------------
> > $ git submodule -n 2 summary sm1
> > # Submodules modifiled: sm1
> > #
> > # * sm1 354cd45...3f751e5:
> > # <one line message for C
> > # <one line message for B
> > # >... (1 more)
> > # >one line message for E
> > #
>
> When you have room only for N lines, you might have to say (X more), but
> you never need to say (1 more). You can fit that omitted one item on that
> line instead of wasting that line to say (1 more).
>
make sense.
>
> > + -n|--summary-limit)
> > + if test -z "$2" || echo "$2" | grep --quiet -v '^-\?[0-9]\+$'
>
> \?\+?????
>
> summary_limit=$(expr "$2" : '[0-9][0-9]*$')
>
> or even
>
> if summary_limit=$(( $2 + 0 )) 2>/dev/null ||
> test "$2" != "$summary_limit"
> then
> usage
> fi
>
> perhaps.
>
> > + if (( $summary_limit < 0 ))
>
> Don't. The first line of this script says "#!/bin/sh", not bash.
>
ok, i'll fix it.
--
Ping Yin
next prev parent reply other threads:[~2008-03-01 10:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 17:34 [PATCH v2 0/3] git-submodule: New subcommand 'summary' Ping Yin
2008-02-29 17:34 ` [PATCH v2 1/3] git-submodule: New subcommand 'summary' (1) - code framework Ping Yin
2008-02-29 17:34 ` [PATCH v2 2/3] git-submodule: New subcommand 'summary' (2) - hard work Ping Yin
2008-02-29 17:34 ` [PATCH v2 3/3] git-submodule: New subcommand 'summary' (3) - limit summary size Ping Yin
2008-03-01 7:29 ` Junio C Hamano
[not found] ` <46dff0320803010216m1bd20674if82d2d2072858290@mail.gmail.com>
2008-03-01 10:29 ` Ping Yin [this message]
2008-03-01 12:42 ` Ping Yin
2008-03-01 20:26 ` Junio C Hamano
2008-03-01 7:29 ` [PATCH v2 2/3] git-submodule: New subcommand 'summary' (2) - hard work Junio C Hamano
2008-03-01 11:04 ` Ping Yin
2008-03-07 16:50 ` Ping Yin
2008-03-07 16:59 ` Jakub Narebski
2008-03-07 18:23 ` Ping Yin
2008-03-07 18:46 ` Junio C Hamano
2008-03-01 7:28 ` [PATCH v2 1/3] git-submodule: New subcommand 'summary' (1) - code framework Junio C Hamano
2008-03-01 10:27 ` Ping Yin
2008-03-01 20:52 ` Junio C Hamano
2008-03-02 2:16 ` Junio C Hamano
2008-03-02 5:11 ` Ping Yin
[not found] ` <46dff0320803010201q72a72et951e0a3f090684e4@mail.gmail.com>
2008-03-01 10:28 ` Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dff0320803010229h17b810a7k26d0ac36cf1eaef6@mail.gmail.com \
--to=pkufranky@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).