From: Johannes Sixt <j6t@kdbg.org>
To: Carlo Arenas <carenas@gmail.com>
Cc: shoelzer@gmail.com, gitgitgadget@gmail.com, git@vger.kernel.org,
gitster@pobox.com, johannes.schindelin@gmx.de
Subject: Re: [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues
Date: Sat, 3 Nov 2018 15:05:54 +0100 [thread overview]
Message-ID: <46aa1893-095b-9f0c-4989-e63ebaa88705@kdbg.org> (raw)
In-Reply-To: <CAPUEspgF0GjJPtMqmZjUmsEeaJpQQBBwOV9YOg8A6YBdwbdaFA@mail.gmail.com>
Am 03.11.18 um 09:14 schrieb Carlo Arenas:
> On Fri, Nov 2, 2018 at 9:44 AM Johannes Sixt <j6t@kdbg.org> wrote:
>>
>> + timeout = elapsed >= orig_timeout ? 0 : (int)(orig_timeout - elapsed);
>
> nitpick: cast to DWORD instead of int
No; timeout is of type int; after an explicit type cast we don't want to
have another implicit conversion.
-- Hannes
next prev parent reply other threads:[~2018-11-03 14:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 21:11 [PATCH 0/1] Make compat/poll safer on Windows Johannes Schindelin via GitGitGadget
2018-10-31 21:11 ` [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues Steve Hoelzer via GitGitGadget
2018-11-01 10:21 ` Johannes Sixt
2018-11-02 14:47 ` Steve Hoelzer
2018-11-02 16:43 ` Johannes Sixt
2018-11-02 17:18 ` Steve Hoelzer
2018-11-03 0:39 ` Junio C Hamano
2018-11-03 0:49 ` Junio C Hamano
2018-11-03 8:14 ` Carlo Arenas
2018-11-03 14:05 ` Johannes Sixt [this message]
2018-11-04 23:26 ` Junio C Hamano
2018-11-04 23:44 ` Randall S. Becker
2018-11-05 3:33 ` Eric Sunshine
2018-11-05 4:02 ` Junio C Hamano
2018-11-05 7:01 ` Johannes Sixt
2018-11-05 20:28 ` Johannes Sixt
2018-11-05 22:05 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46aa1893-095b-9f0c-4989-e63ebaa88705@kdbg.org \
--to=j6t@kdbg.org \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=shoelzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).