From: Marius Storm-Olsen <marius@trolltech.com>
To: Johannes Sixt <j.sixt@eudaptics.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Johannes Sixt <johannes.sixt@telecom.at>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API
Date: Tue, 04 Sep 2007 12:20:03 +0200 [thread overview]
Message-ID: <46DD3153.8060805@trolltech.com> (raw)
In-Reply-To: <46DD0C16.70101@eudaptics.com>
[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]
Johannes Sixt said the following on 04.09.2007 09:41:
> Marius Storm-Olsen schrieb:
>> Johannes Schindelin wrote:
>>> To make it easier on others, I just uploaded it into the
>>> "teststat" branch on 4msysgit.git (subject to removal in a few
>>> days).
>> Ok, I've updated the patch in the 4msysgit.git repo, 'teststat'
>> branch. RFC, and please test.
>
> Thanks a lot! I've pushed it out in mingw.git's master.
Ops, already in master branch?
Ok, I found out that the custom fstat function was incomplete, so I
completed it. However, since you've already pushed it to your main
branch, I've added it as a separate commit to the 4msysgit.git
'teststat' branch. It might also explain some of the testfailures we
were seeing, but I haven't finished the test run yet. (So, consider
the patch something to play with, and don't commit it to your 'master'
branch yet! ;-)
http://repo.or.cz/w/git/mingw/4msysgit.git?a=commitdiff;h=f15974add93bdfa92775c77c00e7c65aefd42127
> The reason that t4200-rerere.sh fails is that we now store UTC in
> st_mtime. However, for the garbage-collection we compare this entry
> to a local time stamp. Therefore, I've pushed out a fixup patch at
> the top of mingw.git's devel branch that converts mtime to local
> time
> (http://repo.or.cz/w/git/mingw.git?a=commitdiff;h=1b62ecb31068af06c2fa7664f06c6c36316aac2c).
> Would you kindly conduct the performance test with this patch? I'm
> afraid that this makes us substantially slower.
Ok, I can give it a performance test, but I tend to agree with David
Kastrup there. It would be better if we rather fix the places where we
check with the local timestamp instead; depending of course on how
many places we actually do this.
We'll see how much the timezone conversion in the custom stat
functions actually hurt us performance wise.
--
.marius
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 187 bytes --]
next prev parent reply other threads:[~2007-09-04 10:20 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 14:49 Stats in Git Marius Storm-Olsen
2007-09-02 14:51 ` [PATCH] Add a new lstat implementation based on Win32 API, and make stat use that implementation too Marius Storm-Olsen
2007-09-02 14:57 ` Marius Storm-Olsen
2007-09-02 15:32 ` Reece Dunn
2007-09-02 16:09 ` Marius Storm-Olsen
2007-09-02 16:33 ` Reece Dunn
2007-09-02 16:47 ` Brian Gernhardt
2007-09-02 16:53 ` Reece Dunn
2007-09-02 17:05 ` Marius Storm-Olsen
2007-09-02 17:44 ` Johannes Schindelin
2007-09-02 17:58 ` David Kastrup
2007-09-02 18:18 ` Marius Storm-Olsen
2007-09-02 18:16 ` Johannes Sixt
2007-09-02 18:44 ` Marius Storm-Olsen
2007-09-02 19:07 ` Johannes Sixt
2007-09-02 19:31 ` Marius Storm-Olsen
2007-09-02 20:27 ` Robin Rosenberg
2007-09-02 21:26 ` Johannes Schindelin
2007-09-02 21:42 ` Robin Rosenberg
2007-09-02 23:02 ` Johannes Schindelin
2007-09-03 7:07 ` Johannes Sixt
2007-09-03 11:21 ` Miklos Vajna
2007-09-03 11:32 ` David Kastrup
2007-09-05 16:02 ` Miklos Vajna
2007-09-05 19:01 ` David Kastrup
2007-09-06 16:26 ` Miklos Vajna
2007-09-06 16:33 ` David Kastrup
2007-09-06 23:31 ` Douglas Stockwell
2007-09-07 6:36 ` David Kastrup
2007-09-02 21:38 ` Alex Riesen
2007-09-02 22:04 ` Robin Rosenberg
2007-09-03 6:15 ` Marius Storm-Olsen
2007-09-03 11:39 ` Johannes Schindelin
2007-09-03 11:51 ` David Kastrup
2007-09-03 11:53 ` Marius Storm-Olsen
2007-09-03 12:33 ` Johannes Schindelin
2007-09-02 21:41 ` Alex Riesen
2007-09-03 6:12 ` Marius Storm-Olsen
2007-09-03 7:47 ` Johannes Sixt
2007-09-03 7:55 ` Marius Storm-Olsen
[not found] ` <46DBFA2A.7050003@trolltech.com>
2007-09-03 12:38 ` [PATCH] Add a new lstat and fstat implementation based on Win32 API Marius Storm-Olsen
2007-09-03 13:33 ` Johannes Schindelin
2007-09-03 13:52 ` Marius Storm-Olsen
2007-09-03 14:39 ` Johannes Schindelin
2007-09-03 16:22 ` Marius Storm-Olsen
2007-09-03 16:56 ` Johannes Schindelin
2007-09-03 13:53 ` Johannes Sixt
2007-09-03 14:35 ` Johannes Schindelin
2007-09-03 19:21 ` Marius Storm-Olsen
2007-09-04 2:21 ` Johannes Schindelin
2007-09-04 7:41 ` Johannes Sixt
2007-09-04 8:53 ` David Kastrup
2007-09-04 10:20 ` Marius Storm-Olsen [this message]
2007-09-04 10:53 ` Johannes Sixt
2007-09-04 11:21 ` Marius Storm-Olsen
2007-09-04 11:28 ` Johannes Sixt
2007-09-04 21:31 ` David Kastrup
2007-09-04 10:48 ` Johannes Schindelin
2007-09-04 11:36 ` Johannes Sixt
2007-09-04 11:53 ` Marius Storm-Olsen
2007-09-04 13:56 ` Marius Storm-Olsen
2007-09-04 14:07 ` Johannes Sixt
2007-09-04 14:32 ` Johannes Schindelin
2007-09-04 14:52 ` Johannes Sixt
2007-09-04 14:16 ` Johannes Schindelin
2007-09-04 14:30 ` Johannes Schindelin
2007-09-04 14:43 ` Marius Storm-Olsen
2007-09-04 14:48 ` Johannes Schindelin
2007-09-04 15:05 ` David Kastrup
2007-09-04 16:32 ` Marius Storm-Olsen
2007-09-04 12:46 ` Johannes Schindelin
2007-09-04 12:57 ` Johannes Schindelin
2007-09-04 21:02 ` Rutger Nijlunsing
2007-09-04 21:54 ` Reece Dunn
2007-09-05 6:22 ` Marius Storm-Olsen
2007-09-05 10:15 ` Johannes Schindelin
2007-09-04 13:03 ` Johannes Sixt
2007-09-06 16:18 ` Johannes Sixt
2007-09-06 16:34 ` Marius Storm-Olsen
2007-09-03 13:49 ` Johannes Sixt
2007-09-03 14:38 ` Johannes Schindelin
2007-09-03 16:15 ` Marius Storm-Olsen
2007-09-03 16:55 ` Johannes Schindelin
2007-09-02 20:02 ` Stats in Git Alex Riesen
2007-09-02 20:09 ` Marius Storm-Olsen
2007-09-03 8:19 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DD3153.8060805@trolltech.com \
--to=marius@trolltech.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=j.sixt@eudaptics.com \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).