From: Andy Whitcroft <apw@shadowen.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Fredrik Kuivinen <frekui@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-reset --hard: use quotes when we tell the user what HEAD was reset to
Date: Mon, 08 Jan 2007 08:33:49 +0000 [thread overview]
Message-ID: <45A201ED.8030003@shadowen.org> (raw)
In-Reply-To: <7vfyam1r18.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> "Fredrik Kuivinen" <frekui@gmail.com> writes:
>
>>>> I think we need to delimit the name better, probabally we need to quote
>>>> it. Perhaps something like:
>>>>
>>>> HEAD is now at ac9c110: "git-fetch: remove .keep file at the end".
>>> ...
>> I don't think the second point is much of an issue. Is it really that
>> irritating to
>> read a word-wrapped line of text? I agree with the first point though, in most
>> cases it will not be a problem in other projects.
>>
>> I still think it is worth doing it, but it certainly isn't super
>> important. Feel free
>> to drop the patch if you want to.
>
> I do not care much either way, but the third point is that the
> quoted output would look "interesting" if the original title
> text has double-quoted words. I.e.
>
> HEAD is now at 9945d98: "Add "--cacheinfo" option to update-cache."
>
> Notice also your hand-wrapped example has the final full-stop
> outside the quote, which your patch would not produce ;-).
Heh, well perhaps I should use the original for a while longer and see
if I get used to it. Of course I mostly use git on git and linux which
both tend to have "error" in their titles :).
-apw
prev parent reply other threads:[~2007-01-08 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 10:23 [PATCH] git-reset --hard: use quotes when we tell the user what HEAD was reset to Fredrik Kuivinen
2007-01-06 19:26 ` Junio C Hamano
2007-01-07 12:56 ` Fredrik Kuivinen
2007-01-07 21:10 ` Junio C Hamano
2007-01-08 8:33 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A201ED.8030003@shadowen.org \
--to=apw@shadowen.org \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).