From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: noloader@gmail.com, Git List <git@vger.kernel.org>
Subject: Re: Does Git build things during 'make install"?
Date: Mon, 16 Oct 2017 19:13:42 +0200 [thread overview]
Message-ID: <446559c7-364a-fb33-905a-74b487900d3b@kdbg.org> (raw)
In-Reply-To: <xmqq60bfsdpj.fsf@gitster.mtv.corp.google.com>
Am 16.10.2017 um 10:23 schrieb Junio C Hamano:
> Johannes Sixt <j6t@kdbg.org> writes:
>
>> Yes, running "sudo make install" is a nightmare. sudo clears the path,
>> and the git command is not found by the make invoked with root
>> permissions. This changes the version string that gets compiled into
>> the executable, which finally triggers a complete rebuild under
>> root. Sad...
>
> In the meantime, would it help to intall as yourself under DESTDIR
> set to where you can write into, and then limit the potential
> damange done while pretending to be a privileged user to "cp -R" (or
> "tar cf" in $DESTDIR piped to "tar xf" in /)?
>
> It appears that some dependencies are screwed up around "perl"
> related things, which may want to get fixed. I agree that "make &&
> make install" that runs two 'make' under the same environment and
> user shouldn't (re)build anything during the latter 'make', but we
> somehow seem to do so.
We do so only, if 'make install' does not run in the same environment
and if there is no version file.
I use the patch below. It works for me, but I could imagine that it
suffers from the original problem if there is no git in PATH and there
is no version file, i.e., when the source is not a release tarball.
----- 8< -----
Subject: [PATCH] version-gen: Use just built git if no other git is in PATH
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
GIT-VERSION-GEN | 3 +++
1 file changed, 3 insertions(+)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index 0e88e23653..b610aa3249 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -3,6 +3,9 @@
GVF=GIT-VERSION-FILE
DEF_VER=v2.15.0-rc1
+# use git that was just compiled if there is no git elsewhere in PATH
+PATH=$PATH:.
+
LF='
'
--
2.14.2.808.g3bc32f2729
prev parent reply other threads:[~2017-10-16 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 5:05 Does Git build things during 'make install"? Jeffrey Walton
2017-10-16 5:58 ` Johannes Sixt
2017-10-16 8:23 ` Junio C Hamano
2017-10-16 17:13 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446559c7-364a-fb33-905a-74b487900d3b@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=noloader@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).