From: Andreas Ericsson <ae@op5.se>
To: git@vger.kernel.org
Subject: Re: [PATCH 4/4] git-daemon support for user-relative paths.
Date: Wed, 02 Nov 2005 10:39:15 +0100 [thread overview]
Message-ID: <43688943.4010002@op5.se> (raw)
In-Reply-To: <7v1x1zv1ln.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Andreas Ericsson <ae@op5.se> writes:
>
>
>>Junio C Hamano wrote:
>>
>>>>-static int log_syslog;
>>>>+static int log_syslog = 0;
>>>
>>>I'd drop this.
>>
>>No can do. It has to be set either here or down in main. It's nice to
>>have the default in the declaration.
>
>
> Isn't "static int log_syslog" in BSS to be initialized to zero anyway?
>
I would have thought so, but it wasn't when I tested it. This could be a
compiler-bug in my end, I suppose, but spelling it out enhances
readability and leaves no room for doubt which is always nice.
>>
>>Ok. I'll take that to mean "hold off on the --server-root and --userdir
>>patch for a while" then.
>
>
> I do not mind keeping it in the proposed updates branch for
> people to see and experiment with, but not in the master branch,
> at least for now.
>
I'll cook it up then.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2005-11-02 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 22:59 [PATCH 4/4] git-daemon support for user-relative paths Andreas Ericsson
2005-11-02 0:14 ` Junio C Hamano
2005-11-02 8:17 ` Andreas Ericsson
2005-11-02 9:30 ` Junio C Hamano
2005-11-02 9:39 ` Andreas Ericsson [this message]
2005-11-02 8:21 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43688943.4010002@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).