mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <>
To: Junio C Hamano <>,
	Derrick Stolee via GitGitGadget <>
Subject: Re: [PATCH 0/3] Close commit-graph before calling 'gc'
Date: Mon, 20 May 2019 07:05:31 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 5/18/2019 10:04 PM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <> writes:
>> This series adds close_commit_graph() to close_all_packs() and then renames 
>> close_all_packs() to close_object_store(). This name is more descriptive of
>> its larger purpose.
> OK.  Somebody needs to go though all the existing callers of
> close_all_packs() to see if the above claim is true (unless you
> haven't done so, that is), but I really like the general direction.

Here is a full inventory. Most of the context can be found simply by
'git grep -B 10 -A 10 close_object_store' but some cases need reading
a helper function to know for sure.

About to call gc or repack:

* am
* clone
* fetch
* merge
* rebase
* receive-pack

Is about to delete packs or pack-garbage:

* gc
* repack

And in object.c, we are in the "raw_object_store_clear()" method.


  parent reply	other threads:[~2019-05-20 11:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 18:41 [PATCH 0/3] Close commit-graph before calling 'gc' Derrick Stolee via GitGitGadget
2019-05-17 18:41 ` [PATCH 1/3] commit-graph: use raw_object_store when closing Derrick Stolee via GitGitGadget
2019-05-17 18:41 ` [PATCH 2/3] packfile: close commit-graph in close_all_packs Derrick Stolee via GitGitGadget
2019-05-17 18:41 ` [PATCH 3/3] packfile: close_all_packs to close_object_store Derrick Stolee via GitGitGadget
2019-05-20 10:01   ` Johannes Schindelin
2019-05-20 11:55     ` Derrick Stolee
2019-05-28 16:29       ` Junio C Hamano
2019-05-19  2:04 ` [PATCH 0/3] Close commit-graph before calling 'gc' Junio C Hamano
2019-05-20 10:13   ` Johannes Schindelin
2019-05-20 11:05   ` Derrick Stolee [this message]
2019-05-20  9:40 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).