* Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init
@ 2005-07-11 1:58 Joel Becker
2005-07-11 4:01 ` Bryan Larsen
0 siblings, 1 reply; 2+ messages in thread
From: Joel Becker @ 2005-07-11 1:58 UTC (permalink / raw
To: Petr Baudis, git
Petr,
Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 contains the
chunk:
-uri=$1
+
+infoonly=
+while optparse; do
+ if optparse -N; then
+ infoonly=-N
+ else
+ optfail
+ fi
+done
+
+uri=$ARGV
However, $ARGV is not a variable I've ever seen supported in a
Bourne-like shell. Certainly Bash supports BASH_ARGV, but not ARGV.
The recent option parsing code adds ARGS in cg-Xlib, but not
ARGV.
The upshot is that a cg-clone/cg-init attempt thinks $uri is
empty, and always creates an initial commit. No clone. I don't know
how folks have gotten cg-clone rsync://linus to work since this change
went in.
I don't know what the proper solution is with the modern option
code, but changing it back to 'url=$1' allows me to grab Linus' tree.
Joel
--
Life's Little Instruction Book #3
"Watch a sunrise at least once a year."
Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init
2005-07-11 1:58 Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init Joel Becker
@ 2005-07-11 4:01 ` Bryan Larsen
0 siblings, 0 replies; 2+ messages in thread
From: Bryan Larsen @ 2005-07-11 4:01 UTC (permalink / raw
To: Joel Becker; +Cc: Petr Baudis, git
Yes, I meant to use $ARGS. I included the fix in the patchset I just sent.
Sorry,
Bryan
Joel Becker wrote:
> Petr,
> Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 contains the
> chunk:
>
> -uri=$1
> +
> +infoonly=
> +while optparse; do
> + if optparse -N; then
> + infoonly=-N
> + else
> + optfail
> + fi
> +done
> +
> +uri=$ARGV
>
> However, $ARGV is not a variable I've ever seen supported in a
> Bourne-like shell. Certainly Bash supports BASH_ARGV, but not ARGV.
> The recent option parsing code adds ARGS in cg-Xlib, but not
> ARGV.
> The upshot is that a cg-clone/cg-init attempt thinks $uri is
> empty, and always creates an initial commit. No clone. I don't know
> how folks have gotten cg-clone rsync://linus to work since this change
> went in.
> I don't know what the proper solution is with the modern option
> code, but changing it back to 'url=$1' allows me to grab Linus' tree.
>
> Joel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-11 4:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-11 1:58 Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init Joel Becker
2005-07-11 4:01 ` Bryan Larsen
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).