From: Ramsay Jones <firstname.lastname@example.org>
To: "brian m. carlson" <email@example.com>,
Junio C Hamano <firstname.lastname@example.org>,
GIT Mailing-list <email@example.com>
Subject: Re: [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning
Date: Wed, 29 Nov 2017 17:58:47 +0000 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On 29/11/17 01:35, brian m. carlson wrote:
> On Tue, Nov 28, 2017 at 03:01:19AM +0000, Ramsay Jones wrote:
>> Commit 78a6766802 ("Integrate hash algorithm support with repo setup",
>> 2017-11-12) added a 'const struct git_hash_algo *hash_algo' field to the
>> repository structure, without modifying the initializer of the 'the_repo'
>> variable. This does not actually introduce a bug, since the '0' initializer
>> for the 'ignore_env:1' bit-field is interpreted as a NULL pointer (hence
>> the warning), and the final field (now with no initializer) receives a
>> default '0'.
>> Signed-off-by: Ramsay Jones <email@example.com>
>> Hi Junio,
>> I don't recall Brian doing a re-roll of the 'bc/hash-algo' branch, but
>> now that it has been merged into the 'next' branch, sparse is barking on
>> that branch too. This patch (slightly different to the last one) applies
>> on top of 'next'.
> Thanks for the patch; it's obviously correct. I'll get sparse set up
> for future patch series.
Heh, at this point I usually remark that you would need to build
sparse from source, since all the packaged versions are so old
as to be virtually useless (to run over git).
That may still be the case, depending on your distro, since there
was a new release a couple of months ago. However, you know how
long it takes to get into some distros! ;-)
[I _think_ it may be in Debian Unstable]
Oh, the release (v0.5.1) was tagged on 17 Aug 2017.
(I'm currently running v0.5.1-30-gf1e4ba1, built from source).
prev parent reply other threads:[~2017-11-29 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 3:01 [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning Ramsay Jones
2017-11-28 4:07 ` Junio C Hamano
2017-11-29 1:35 ` brian m. carlson
2017-11-29 17:58 ` Ramsay Jones [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).