git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ramkumar Ramachandra" <r@artagnon.com>
To: "René Scharfe" <l.s.r@web.de>, "Junio C Hamano" <gitster@pobox.com>
Cc: "Git List" <git@vger.kernel.org>,
	"Christian Couder" <christian.couder@gmail.com>
Subject: Re: git bisect bad @
Date: Thu, 13 Jan 2022 10:32:35 +0100	[thread overview]
Message-ID: <421215c1-f6ae-4ec2-b666-2a481056ef79@www.fastmail.com> (raw)
In-Reply-To: <5be4cdad-6769-68e8-0984-5fe89668d007@web.de>

René Scharfe wrote:
> > Am 12.01.22 um 18:50 schrieb Junio C Hamano:
> > So exit code values are only very vaguely standardized.  It's very
> > possible that there are programs that use 126 or 127 to signal
> > something other than "can't execute" or "cannot find command".  Under
> > the new rules the bisect run script would have to translate them to
> > some lower value.
> 
> Reserving 126 and 127 shouldn't cause too much trouble, but there's
> also a way to avoid it: bisect run could checkout a known-good
> revision first and abort if the script returns non-zero for any
> reason, including its non-existence.

I can't say I'm overly enthusiastic about this trade-off. I think most people would check their bisect scripts against the good revision by hand before starting bisect: why introduce one redundant step for users like me who tend to bump their heads, because they're a bit rusty with machines?

Again, I don't know if this is a good idea, but if exit codes from the shell aren't standardized, surely fork() and exec() would have a better spec? So, perhaps remove the little git-bisect.sh and rewrite it in C? I'd be up for this task, if we decide that this is a better way to go.

Warm regards,
Ram

  reply	other threads:[~2022-01-13  9:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-09 19:29 git bisect bad @ Ramkumar Ramachandra
2022-01-09 19:54 ` Junio C Hamano
2022-01-09 20:48   ` Ramkumar Ramachandra
2022-01-10  9:01     ` [PATCH] bisect: report actual bisect_state() argument on error René Scharfe
2022-01-10 10:04       ` Ramkumar Ramachandra
2022-01-10 17:06     ` git bisect bad @ Junio C Hamano
2022-01-10 21:04       ` Ramkumar Ramachandra
2022-01-12  9:04         ` René Scharfe
2022-01-12 17:50           ` Junio C Hamano
2022-01-12 18:34             ` René Scharfe
2022-01-13  5:10               ` René Scharfe
2022-01-13  9:32                 ` Ramkumar Ramachandra [this message]
2022-01-13 12:28                   ` Christian Couder
2022-01-13 13:55                     ` René Scharfe
2022-01-13 15:16                       ` Ramkumar Ramachandra
2022-01-14  7:47                         ` René Scharfe
2022-01-14  8:04                           ` Ramkumar Ramachandra
2022-01-18 12:45                             ` René Scharfe
2022-01-14 18:42                           ` Junio C Hamano
2022-01-13 18:40                       ` Junio C Hamano
2022-01-18 12:45     ` [PATCH v2 1/4] bisect--helper: report actual bisect_state() argument on error René Scharfe
2022-01-18 12:46     ` [PATCH v2 2/4] bisect--helper: release strbuf and strvec on run error René Scharfe
2022-01-18 12:46     ` [PATCH v2 3/4] bisect: document run behavior with exit codes 126 and 127 René Scharfe
2022-01-18 12:46     ` [PATCH v2 4/4] bisect--helper: double-check run command on exit code " René Scharfe
2022-01-19  2:36       ` Junio C Hamano
2022-01-19  7:52         ` René Scharfe
2022-02-04  0:42       ` Junio C Hamano
2022-02-04 17:16         ` René Scharfe
2022-02-04 18:16         ` Ramkumar Ramachandra
2022-02-04 19:32           ` Junio C Hamano
2022-02-04 18:09       ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=421215c1-f6ae-4ec2-b666-2a481056ef79@www.fastmail.com \
    --to=r@artagnon.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).