From: Derrick Stolee <stolee@gmail.com> To: Duy Nguyen <pclouds@gmail.com> Cc: "Git Mailing List" <git@vger.kernel.org>, "Stefan Beller" <sbeller@google.com>, "Derrick Stolee" <dstolee@microsoft.com>, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, "Jonathan Nieder" <jrnieder@gmail.com>, "Jonathan Tan" <jonathantanmy@google.com>, "Martin Fick" <mfick@codeaurora.org> Subject: Re: [PATCH 09/23] midx: write pack names in chunk Date: Thu, 21 Jun 2018 11:25:38 -0400 Message-ID: <4082c785-9fb2-7b15-b646-3c658b54abbe@gmail.com> (raw) In-Reply-To: <CACsJy8ARDLeWaWq1_npZq5ARCVgcETpS--YUVLqZkZA52E7Msw@mail.gmail.com> On 6/7/2018 2:26 PM, Duy Nguyen wrote: > On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee <stolee@gmail.com> wrote: >> @@ -74,6 +80,31 @@ struct midxed_git *load_midxed_git(const char *object_dir) >> m->num_chunks = *(m->data + 6); >> m->num_packs = get_be32(m->data + 8); >> >> + for (i = 0; i < m->num_chunks; i++) { >> + uint32_t chunk_id = get_be32(m->data + 12 + MIDX_CHUNKLOOKUP_WIDTH * i); >> + uint64_t chunk_offset = get_be64(m->data + 16 + MIDX_CHUNKLOOKUP_WIDTH * i); > Would be good to reduce magic numbers like 12 and 16, I think you have > some header length constants for those already. > >> + switch (chunk_id) { >> + case MIDX_CHUNKID_PACKNAMES: >> + m->chunk_pack_names = m->data + chunk_offset; >> + break; >> + >> + case 0: >> + die("terminating MIDX chunk id appears earlier than expected"); > _() This die() and others like it are not marked for translation on purpose, as they should never be seen by an end-user. > >> + break; >> + >> + default: >> + /* >> + * Do nothing on unrecognized chunks, allowing future >> + * extensions to add optional chunks. >> + */ > I wrote about the chunk term reminding me of PNG format then deleted > it. But it may help to do similar to PNG here. The first letter can > let us know if the chunk is optional and can be safely ignored. E.g. > uppercase first letter cannot be ignored, lowercase go wild. That's an interesting way to think about it. That way you could add a new "required" chunk and earlier versions could die() realizing they don't know how to parse that required chunk. I think for this format, we should update the file version value when a required chunk is needed. > >> + break; >> + } >> + } >> + >> + if (!m->chunk_pack_names) >> + die("MIDX missing required pack-name chunk"); > _() > >> + >> return m; >> >> cleanup_fail: >> @@ -99,18 +130,88 @@ static size_t write_midx_header(struct hashfile *f, >> return MIDX_HEADER_SIZE; >> } >> >> +struct pack_pair { >> + uint32_t pack_int_id; > can this be just pack_id? Since packfiles are usually named pack-{hash}.pack, I chose to be specific here. > >> + char *pack_name; >> +}; >> + >> +static int pack_pair_compare(const void *_a, const void *_b) >> +{ >> + struct pack_pair *a = (struct pack_pair *)_a; >> + struct pack_pair *b = (struct pack_pair *)_b; >> + return strcmp(a->pack_name, b->pack_name); >> +} >> + >> +static void sort_packs_by_name(char **pack_names, uint32_t nr_packs, uint32_t *perm) >> +{ >> + uint32_t i; >> + struct pack_pair *pairs; >> + >> + ALLOC_ARRAY(pairs, nr_packs); >> + >> + for (i = 0; i < nr_packs; i++) { >> + pairs[i].pack_int_id = i; >> + pairs[i].pack_name = pack_names[i]; >> + } >> + >> + QSORT(pairs, nr_packs, pack_pair_compare); >> + >> + for (i = 0; i < nr_packs; i++) { >> + pack_names[i] = pairs[i].pack_name; >> + perm[pairs[i].pack_int_id] = i; >> + } > pairs[] is leaked? Good catch! > >> +} >> + >> +static size_t write_midx_pack_names(struct hashfile *f, >> + char **pack_names, >> + uint32_t num_packs) >> +{ >> + uint32_t i; >> + unsigned char padding[MIDX_CHUNK_ALIGNMENT]; >> + size_t written = 0; >> + >> + for (i = 0; i < num_packs; i++) { >> + size_t writelen = strlen(pack_names[i]) + 1; >> + >> + if (i && strcmp(pack_names[i], pack_names[i - 1]) <= 0) >> + BUG("incorrect pack-file order: %s before %s", >> + pack_names[i - 1], >> + pack_names[i]); >> + >> + hashwrite(f, pack_names[i], writelen); >> + written += writelen; > side note. This pattern happens a lot. It may be a good idea to make > hashwrite() return writelen so we can just write > > written += hashwrite(f, ..., writelen); If I change the prototype of hashwrite(), will other callers get warnings about not inspecting the return value (for some build options on some platforms)? > >> + } >> + >> + /* add padding to be aligned */ >> + i = MIDX_CHUNK_ALIGNMENT - (written % MIDX_CHUNK_ALIGNMENT); >> + if (i < MIDX_CHUNK_ALIGNMENT) { >> + bzero(padding, sizeof(padding)); >> + hashwrite(f, padding, i); >> + written += i; >> + } >> + >> + return written; >> +} >> + >> int write_midx_file(const char *object_dir) >> { >> - unsigned char num_chunks = 0; >> + unsigned char cur_chunk, num_chunks = 0; >> char *midx_name; >> struct hashfile *f; >> struct lock_file lk; >> struct packed_git **packs = NULL; >> + char **pack_names = NULL; >> + uint32_t *pack_perm; >> uint32_t i, nr_packs = 0, alloc_packs = 0; >> + uint32_t alloc_pack_names = 0; >> DIR *dir; >> struct dirent *de; >> struct strbuf pack_dir = STRBUF_INIT; >> size_t pack_dir_len; >> + uint64_t pack_name_concat_len = 0; >> + uint64_t written = 0; >> + uint32_t chunk_ids[MIDX_MAX_CHUNKS + 1]; >> + uint64_t chunk_offsets[MIDX_MAX_CHUNKS + 1]; > This long list of local vars may be a good indicator that this > function needs split up into smaller ones. Or the data needs to be grouped into structs, which is happening in my local branch due to the for_each_file_in_pack_dir() method. >> midx_name = get_midx_filename(object_dir); >> if (safe_create_leading_directories(midx_name)) { >> @@ -132,12 +233,14 @@ int write_midx_file(const char *object_dir) >> strbuf_addch(&pack_dir, '/'); >> pack_dir_len = pack_dir.len; >> ALLOC_ARRAY(packs, alloc_packs); >> + ALLOC_ARRAY(pack_names, alloc_pack_names); >> while ((de = readdir(dir)) != NULL) { >> if (is_dot_or_dotdot(de->d_name)) >> continue; >> >> if (ends_with(de->d_name, ".idx")) { >> ALLOC_GROW(packs, nr_packs + 1, alloc_packs); >> + ALLOC_GROW(pack_names, nr_packs + 1, alloc_pack_names); >> >> strbuf_setlen(&pack_dir, pack_dir_len); >> strbuf_addstr(&pack_dir, de->d_name); >> @@ -145,21 +248,83 @@ int write_midx_file(const char *object_dir) >> packs[nr_packs] = add_packed_git(pack_dir.buf, >> pack_dir.len, >> 0); >> - if (!packs[nr_packs]) >> + if (!packs[nr_packs]) { >> warning("failed to add packfile '%s'", >> pack_dir.buf); >> - else >> - nr_packs++; >> + continue; >> + } >> + >> + pack_names[nr_packs] = xstrdup(de->d_name); >> + pack_name_concat_len += strlen(de->d_name) + 1; >> + nr_packs++; >> } >> } >> + >> closedir(dir); >> strbuf_release(&pack_dir); >> >> + if (pack_name_concat_len % MIDX_CHUNK_ALIGNMENT) >> + pack_name_concat_len += MIDX_CHUNK_ALIGNMENT - >> + (pack_name_concat_len % MIDX_CHUNK_ALIGNMENT); >> + >> + ALLOC_ARRAY(pack_perm, nr_packs); >> + sort_packs_by_name(pack_names, nr_packs, pack_perm); >> + >> hold_lock_file_for_update(&lk, midx_name, LOCK_DIE_ON_ERROR); >> f = hashfd(lk.tempfile->fd, lk.tempfile->filename.buf); >> FREE_AND_NULL(midx_name); >> >> - write_midx_header(f, num_chunks, nr_packs); >> + cur_chunk = 0; >> + num_chunks = 1; >> + >> + written = write_midx_header(f, num_chunks, nr_packs); >> + >> + chunk_ids[cur_chunk] = MIDX_CHUNKID_PACKNAMES; >> + chunk_offsets[cur_chunk] = written + (num_chunks + 1) * MIDX_CHUNKLOOKUP_WIDTH; >> + >> + cur_chunk++; >> + chunk_ids[cur_chunk] = 0; >> + chunk_offsets[cur_chunk] = chunk_offsets[cur_chunk - 1] + pack_name_concat_len; >> + >> + for (i = 0; i <= num_chunks; i++) { >> + if (i && chunk_offsets[i] < chunk_offsets[i - 1]) >> + BUG("incorrect chunk offsets: %"PRIu64" before %"PRIu64, >> + chunk_offsets[i - 1], >> + chunk_offsets[i]); >> + >> + if (chunk_offsets[i] % MIDX_CHUNK_ALIGNMENT) >> + BUG("chunk offset %"PRIu64" is not properly aligned", >> + chunk_offsets[i]); >> + >> + hashwrite_be32(f, chunk_ids[i]); >> + hashwrite_be32(f, chunk_offsets[i] >> 32); >> + hashwrite_be32(f, chunk_offsets[i]); >> + >> + written += MIDX_CHUNKLOOKUP_WIDTH; >> + } >> + >> + for (i = 0; i < num_chunks; i++) { >> + if (written != chunk_offsets[i]) >> + BUG("inccrrect chunk offset (%"PRIu64" != %"PRIu64") for chunk id %"PRIx32, > incorrect > >> + chunk_offsets[i], >> + written, >> + chunk_ids[i]); >> + >> + switch (chunk_ids[i]) { >> + case MIDX_CHUNKID_PACKNAMES: >> + written += write_midx_pack_names(f, pack_names, nr_packs); >> + break; >> + >> + default: >> + BUG("trying to write unknown chunk id %"PRIx32, >> + chunk_ids[i]); >> + } >> + } >> + >> + if (written != chunk_offsets[num_chunks]) >> + BUG("incorrect final offset %"PRIu64" != %"PRIu64, >> + written, >> + chunk_offsets[num_chunks]); >> >> finalize_hashfile(f, NULL, CSUM_FSYNC | CSUM_HASH_IN_STREAM); >> commit_lock_file(&lk); >> @@ -170,5 +335,6 @@ int write_midx_file(const char *object_dir) >> } >> >> FREE_AND_NULL(packs); >> + FREE_AND_NULL(pack_names); > What about the strings in this array? I think they are xstrdup() but I > didn't spot them being freed. > > And maybe just use string_list... Will do! Thanks.
next prev parent reply other threads:[~2018-06-21 15:25 UTC|newest] Thread overview: 192+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-07 14:03 [PATCH 00/23] Multi-pack-index (MIDX) Derrick Stolee 2018-06-07 14:03 ` [PATCH 01/23] midx: add design document Derrick Stolee 2018-06-11 19:04 ` Stefan Beller 2018-06-18 18:48 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 02/23] midx: add midx format details to pack-format.txt Derrick Stolee 2018-06-11 19:19 ` Stefan Beller 2018-06-18 19:01 ` Derrick Stolee 2018-06-18 19:41 ` Stefan Beller 2018-06-07 14:03 ` [PATCH 03/23] midx: add midx builtin Derrick Stolee 2018-06-07 17:20 ` Duy Nguyen 2018-06-18 19:23 ` Derrick Stolee 2018-06-11 21:02 ` Stefan Beller 2018-06-18 19:40 ` Derrick Stolee 2018-06-18 19:55 ` Stefan Beller 2018-06-18 19:58 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 04/23] midx: add 'write' subcommand and basic wiring Derrick Stolee 2018-06-07 17:27 ` Duy Nguyen 2018-06-07 14:03 ` [PATCH 05/23] midx: write header information to lockfile Derrick Stolee 2018-06-07 17:35 ` Duy Nguyen 2018-06-12 15:00 ` Duy Nguyen 2018-06-19 12:54 ` Derrick Stolee 2018-06-19 14:59 ` Duy Nguyen 2018-06-19 15:24 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 06/23] midx: struct midxed_git and 'read' subcommand Derrick Stolee 2018-06-07 17:54 ` Duy Nguyen 2018-06-20 13:13 ` Derrick Stolee 2018-06-07 18:31 ` Duy Nguyen 2018-06-20 13:33 ` Derrick Stolee 2018-06-20 15:07 ` Duy Nguyen 2018-06-20 16:39 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 07/23] midx: expand test data Derrick Stolee 2018-06-07 14:03 ` [PATCH 08/23] midx: read packfiles from pack directory Derrick Stolee 2018-06-07 18:03 ` Duy Nguyen 2018-06-20 16:33 ` [PATCH] packfile: generalize pack directory list Derrick Stolee 2018-06-07 14:03 ` [PATCH 09/23] midx: write pack names in chunk Derrick Stolee 2018-06-07 18:26 ` Duy Nguyen 2018-06-21 15:25 ` Derrick Stolee [this message] 2018-06-21 17:38 ` Junio C Hamano 2018-06-22 18:25 ` Derrick Stolee 2018-06-22 18:31 ` Junio C Hamano 2018-06-22 18:32 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 10/23] midx: write a lookup into the pack names chunk Derrick Stolee 2018-06-09 16:43 ` Duy Nguyen 2018-06-21 17:23 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 11/23] midx: sort and deduplicate objects from packfiles Derrick Stolee 2018-06-09 17:07 ` Duy Nguyen 2018-06-21 17:54 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 12/23] midx: write object ids in a chunk Derrick Stolee 2018-06-09 17:25 ` Duy Nguyen 2018-06-07 14:03 ` [PATCH 13/23] midx: write object id fanout chunk Derrick Stolee 2018-06-09 17:28 ` Duy Nguyen 2018-06-21 19:49 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 14/23] midx: write object offsets Derrick Stolee 2018-06-09 17:41 ` Duy Nguyen 2018-06-07 14:03 ` [PATCH 15/23] midx: create core.midx config setting Derrick Stolee 2018-06-07 14:03 ` [PATCH 16/23] midx: prepare midxed_git struct Derrick Stolee 2018-06-09 17:47 ` Duy Nguyen 2018-06-07 14:03 ` [PATCH 17/23] midx: read objects from multi-pack-index Derrick Stolee 2018-06-09 17:56 ` Duy Nguyen 2018-06-21 20:03 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 18/23] midx: use midx in abbreviation calculations Derrick Stolee 2018-06-09 18:01 ` Duy Nguyen 2018-06-22 18:38 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 19/23] midx: use existing midx when writing new one Derrick Stolee 2018-06-07 14:03 ` [PATCH 20/23] midx: use midx in approximate_object_count Derrick Stolee 2018-06-09 18:03 ` Duy Nguyen 2018-06-22 18:39 ` Derrick Stolee 2018-06-07 14:03 ` [PATCH 21/23] midx: prevent duplicate packfile loads Derrick Stolee 2018-06-09 18:05 ` Duy Nguyen 2018-06-07 14:03 ` [PATCH 22/23] midx: use midx to find ref-deltas Derrick Stolee 2018-06-07 14:03 ` [PATCH 23/23] midx: clear midx on repack Derrick Stolee 2018-06-09 18:13 ` Duy Nguyen 2018-06-22 18:44 ` Derrick Stolee 2018-06-07 14:06 ` [PATCH 00/23] Multi-pack-index (MIDX) Derrick Stolee 2018-06-07 14:45 ` Ævar Arnfjörð Bjarmason 2018-06-07 14:54 ` Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 00/24] " Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 01/24] multi-pack-index: add design document Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 02/24] multi-pack-index: add format details Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 03/24] multi-pack-index: add builtin Derrick Stolee 2018-06-25 19:15 ` Junio C Hamano 2018-06-25 14:34 ` [PATCH v2 04/24] multi-pack-index: add 'write' verb Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 05/24] midx: write header information to lockfile Derrick Stolee 2018-06-25 19:19 ` Junio C Hamano 2018-07-05 19:13 ` Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 06/24] multi-pack-index: load into memory Derrick Stolee 2018-06-25 19:38 ` Junio C Hamano 2018-07-05 14:19 ` Derrick Stolee 2018-07-05 18:58 ` Eric Sunshine 2018-07-06 19:20 ` Junio C Hamano 2018-06-25 14:34 ` [PATCH v2 07/24] multi-pack-index: expand test data Derrick Stolee 2018-06-25 19:45 ` Junio C Hamano 2018-06-25 14:34 ` [PATCH v2 08/24] packfile: generalize pack directory list Derrick Stolee 2018-06-25 19:57 ` Junio C Hamano 2018-06-25 14:34 ` [PATCH v2 09/24] multi-pack-index: read packfile list Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 10/24] multi-pack-index: write pack names in chunk Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 11/24] midx: read pack names into array Derrick Stolee 2018-06-25 23:52 ` Eric Sunshine 2018-06-25 14:34 ` [PATCH v2 12/24] midx: sort and deduplicate objects from packfiles Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 13/24] midx: write object ids in a chunk Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 14/24] midx: write object id fanout chunk Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 15/24] midx: write object offsets Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 16/24] config: create core.multiPackIndex setting Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 17/24] midx: prepare midxed_git struct Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 18/24] midx: read objects from multi-pack-index Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 19/24] midx: use midx in abbreviation calculations Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 20/24] midx: use existing midx when writing new one Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 21/24] midx: use midx in approximate_object_count Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 22/24] midx: prevent duplicate packfile loads Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 23/24] packfile: skip loading index if in multi-pack-index Derrick Stolee 2018-06-25 14:34 ` [PATCH v2 24/24] midx: clear midx on repack Derrick Stolee 2018-07-06 0:52 ` [PATCH v3 00/24] Multi-pack-index (MIDX) Derrick Stolee 2018-07-06 0:52 ` [PATCH v3 01/24] multi-pack-index: add design document Derrick Stolee 2018-07-06 0:52 ` [PATCH v3 02/24] multi-pack-index: add format details Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 03/24] multi-pack-index: add builtin Derrick Stolee 2018-07-06 3:54 ` Eric Sunshine 2018-07-06 0:53 ` [PATCH v3 04/24] multi-pack-index: add 'write' verb Derrick Stolee 2018-07-06 4:07 ` Eric Sunshine 2018-07-06 0:53 ` [PATCH v3 05/24] midx: write header information to lockfile Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 06/24] multi-pack-index: load into memory Derrick Stolee 2018-07-06 4:19 ` Eric Sunshine 2018-07-06 5:18 ` Eric Sunshine 2018-07-09 19:08 ` Junio C Hamano 2018-07-12 16:06 ` Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 07/24] multi-pack-index: expand test data Derrick Stolee 2018-07-06 4:36 ` Eric Sunshine 2018-07-06 5:20 ` Eric Sunshine 2018-07-12 14:10 ` Derrick Stolee 2018-07-12 18:02 ` Eric Sunshine 2018-07-12 18:06 ` Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 08/24] packfile: generalize pack directory list Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 09/24] multi-pack-index: read packfile list Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 10/24] multi-pack-index: write pack names in chunk Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 11/24] midx: read pack names into array Derrick Stolee 2018-07-06 4:58 ` Eric Sunshine 2018-07-06 0:53 ` [PATCH v3 12/24] midx: sort and deduplicate objects from packfiles Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 13/24] midx: write object ids in a chunk Derrick Stolee 2018-07-06 5:04 ` Eric Sunshine 2018-07-06 0:53 ` [PATCH v3 14/24] midx: write object id fanout chunk Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 15/24] midx: write object offsets Derrick Stolee 2018-07-06 5:27 ` Eric Sunshine 2018-07-12 16:33 ` Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 16/24] config: create core.multiPackIndex setting Derrick Stolee 2018-07-06 5:39 ` Eric Sunshine 2018-07-12 13:19 ` Derrick Stolee 2018-07-12 16:30 ` Derrick Stolee 2018-07-11 9:48 ` SZEDER Gábor 2018-07-12 13:01 ` Derrick Stolee 2018-07-12 13:31 ` SZEDER Gábor 2018-07-12 15:40 ` Derrick Stolee 2018-07-12 17:29 ` Junio C Hamano 2018-07-06 0:53 ` [PATCH v3 17/24] midx: prepare midxed_git struct Derrick Stolee 2018-07-06 5:41 ` Eric Sunshine 2018-07-06 0:53 ` [PATCH v3 18/24] midx: read objects from multi-pack-index Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 19/24] midx: use midx in abbreviation calculations Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 20/24] midx: use existing midx when writing new one Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 21/24] midx: use midx in approximate_object_count Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 22/24] midx: prevent duplicate packfile loads Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 23/24] packfile: skip loading index if in multi-pack-index Derrick Stolee 2018-07-06 0:53 ` [PATCH v3 24/24] midx: clear midx on repack Derrick Stolee 2018-07-06 5:52 ` Eric Sunshine 2018-07-12 19:39 ` [PATCH v4 00/23] Multi-pack-index (MIDX) Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 01/23] multi-pack-index: add design document Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 02/23] multi-pack-index: add format details Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 03/23] multi-pack-index: add builtin Derrick Stolee 2018-07-20 18:22 ` Junio C Hamano 2018-07-20 22:15 ` brian m. carlson 2018-07-20 22:28 ` Junio C Hamano 2018-07-12 19:39 ` [PATCH v4 04/23] multi-pack-index: add 'write' verb Derrick Stolee 2018-07-12 22:56 ` Eric Sunshine 2018-07-12 19:39 ` [PATCH v4 05/23] midx: write header information to lockfile Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 06/23] multi-pack-index: load into memory Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 07/23] t5319: expand test data Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 08/23] packfile: generalize pack directory list Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 09/23] multi-pack-index: read packfile list Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 10/23] multi-pack-index: write pack names in chunk Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 11/23] midx: read pack names into array Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 12/23] midx: sort and deduplicate objects from packfiles Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 13/23] midx: write object ids in a chunk Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 14/23] midx: write object id fanout chunk Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 15/23] midx: write object offsets Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 16/23] config: create core.multiPackIndex setting Derrick Stolee 2018-07-12 21:05 ` Junio C Hamano 2018-07-13 0:50 ` Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 17/23] midx: read objects from multi-pack-index Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 18/23] midx: use midx in abbreviation calculations Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 19/23] midx: use existing midx when writing new one Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 20/23] midx: use midx in approximate_object_count Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 21/23] midx: prevent duplicate packfile loads Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 22/23] packfile: skip loading index if in multi-pack-index Derrick Stolee 2018-07-12 19:39 ` [PATCH v4 23/23] midx: clear midx on repack Derrick Stolee 2018-07-12 21:11 ` [PATCH v4 00/23] Multi-pack-index (MIDX) Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4082c785-9fb2-7b15-b646-3c658b54abbe@gmail.com \ --to=stolee@gmail.com \ --cc=avarab@gmail.com \ --cc=dstolee@microsoft.com \ --cc=git@vger.kernel.org \ --cc=jonathantanmy@google.com \ --cc=jrnieder@gmail.com \ --cc=mfick@codeaurora.org \ --cc=pclouds@gmail.com \ --cc=sbeller@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git