From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2B5421F5AE for ; Sat, 13 Jun 2020 11:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726045AbgFMLtS (ORCPT ); Sat, 13 Jun 2020 07:49:18 -0400 Received: from bsmtp.bon.at ([213.33.87.14]:60671 "EHLO bsmtp.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgFMLtS (ORCPT ); Sat, 13 Jun 2020 07:49:18 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp.bon.at (Postfix) with ESMTPSA id 49kbV21LVVz5tlB; Sat, 13 Jun 2020 13:49:14 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id 9F70C41AF; Sat, 13 Jun 2020 13:49:13 +0200 (CEST) Subject: Re: Re* [PATCH 8/9] fast-export: respect the possibly-overridden default branch name To: Junio C Hamano Cc: Johannes Schindelin , Matt Rogers , "brian m. carlson" , Johannes Schindelin via GitGitGadget , Git Mailing List , don@goodman-wilson.com, stolee@gmail.com, Jeff King References: <1efe848f2b029e572cea61cadcfe36b9d3797836.1591823971.git.gitgitgadget@gmail.com> <20200610233912.GU6569@camp.crustytoothpaste.net> From: Johannes Sixt Message-ID: <405521ec-aed7-ff76-5b48-70e9d11018e6@kdbg.org> Date: Sat, 13 Jun 2020 13:49:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 12.06.20 um 17:14 schrieb Junio C Hamano: > /* > * Anonymize the name used for the primary branch in this > * repository, but reserve `ref0` for it, so that it can > * be identified among other refs in the output. > */ > > is the minimum I would expect before calling it an improvement. We > could add > > It is often `main` for new repositories (and `master` for > aged ones) and such well-known names may not need > anonymizing, but it could be configured to use a secret word > that the user may not want to reveal. > > at the end to explain the motivation behind anonymizing even more, > if we wanted to. IMO, making the primary branch identifiable is a reasonable justification to treat it specially. But then, why does it have to be renamed to 'ref0'? Couldn't it just be renamed to Git's default primary branch name, be it 'master' today or 'main' or whatever in the future? After the anonymization, nobody will know whether that was the real name of the primary branch or not. Leaving it at 'master'/'main' reduces the mental burden of the recipient of the anonymous repo. -- Hannes