git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Dmitriy Smirnov <dmitriy.smirnov@jetbrains.com>
To: git@vger.kernel.org
Cc: Kirill Likhodedov <kirill.likhodedov@jetbrains.com>,
	Aleksey Pivovarov <aleksey.pivovarov@jetbrains.com>
Subject: git add —ignore-errors causes --renormalize 
Date: Thu, 17 Jan 2019 18:22:05 +0300	[thread overview]
Message-ID: <401130AF-056B-40BF-8001-8492223B8A6B@jetbrains.com> (raw)

Hello,

Calling `git add —ignore-errors` appears to be equal to calling `git add —renormalize`:

Main.java is saved with CRLF in repo
git config core.autocrlf = input

$ src  git:(master) echo line >> Main.java  
$ src  git:(master) git add --ignore-errors Main.java  
$ src  git:(master) git commit -m "Ignore errors"                          
[master cf24b3b] Ignore errors
 1 file changed, 13 insertions(+), 12 deletions(-)


The reason appears to be wrong bit mask usage

#define ADD_CACHE_IGNORE_ERRORS    4
and
#define HASH_RENORMALIZE  4


Looks like a regression since 2.16.0 - 9472935d81eaf9faed771878c9df0216ae0d9045

             reply	other threads:[~2019-01-17 15:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 15:22 Dmitriy Smirnov [this message]
2019-01-17 16:27 ` git add —ignore-errors causes --renormalize Jeff King
2019-01-17 16:45   ` Jeff King
2019-01-19 17:08   ` Torsten Bögershausen
2019-01-29 21:35   ` SZEDER Gábor
2019-01-29 22:51     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=401130AF-056B-40BF-8001-8492223B8A6B@jetbrains.com \
    --to=dmitriy.smirnov@jetbrains.com \
    --cc=aleksey.pivovarov@jetbrains.com \
    --cc=git@vger.kernel.org \
    --cc=kirill.likhodedov@jetbrains.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).