From: Derrick Stolee <stolee@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Jeff King <peff@peff.net>, Bradley Smith <brad@brad-smith.co.uk>,
Junio C Hamano <gitster@pobox.com>,
James Coglan <jcoglan@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: Assertion in git log graphing [regression in v2.25]
Date: Tue, 7 Jan 2020 07:56:01 -0500 [thread overview]
Message-ID: <3fd8d52c-622e-29a6-442c-66797a3ae1f9@gmail.com> (raw)
In-Reply-To: <CAPig+cRH-yeHmeikf=cbTTMDom+7SLtT2dmya=WP7fsy8tTY3g@mail.gmail.com>
On 1/7/2020 7:50 AM, Eric Sunshine wrote:
> On Tue, Jan 7, 2020 at 7:42 AM Derrick Stolee <stolee@gmail.com> wrote:
>> Here is a a patch that reproduces the test failure. It hits the
>> assert, so it definitely fails.
>
> What happens if someone builds the project with NDEBUG? Then the test
> won't fail as expected. Perhaps this patch ought to also change those
> asserts() to `if (...) BUG(...)` to ensure consistent behavior.
A final version of the patch would probably fix the bug and not use
test_expect_failure. The other option would be to replace every
assert() with a macro that did the "if (...) BUG(...);" conversion,
but maybe that's not necessary in general.
-Stolee
next prev parent reply other threads:[~2020-01-07 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 11:24 Assertion in git log graphing Bradley Smith
2020-01-07 11:48 ` Assertion in git log graphing [regression in v2.25] Jeff King
2020-01-07 12:22 ` Derrick Stolee
2020-01-07 12:42 ` Derrick Stolee
2020-01-07 12:50 ` Eric Sunshine
2020-01-07 12:56 ` Derrick Stolee [this message]
2020-01-07 13:14 ` Eric Sunshine
2020-01-07 13:25 ` Derrick Stolee
2020-01-07 14:04 ` Jeff King
2020-01-07 14:22 ` Derrick Stolee
2020-01-07 14:43 ` Derrick Stolee
2020-01-07 14:57 ` Assertion in git log graphing Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fd8d52c-622e-29a6-442c-66797a3ae1f9@gmail.com \
--to=stolee@gmail.com \
--cc=brad@brad-smith.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jcoglan@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).