From: Derrick Stolee <stolee@gmail.com>
To: Clement Moyroud <clement.moyroud@gmail.com>, git@vger.kernel.org
Subject: Re: Git blame performance on files with a lot of history
Date: Fri, 14 Dec 2018 16:31:24 -0500 [thread overview]
Message-ID: <3f3e7b11-19ef-cc2f-3bd4-e03d9ba8dc91@gmail.com> (raw)
In-Reply-To: <CABXAcUzoNJ6s3=2xZfWYQUZ_AUefwP=5UVUgMnafKHHtufzbSA@mail.gmail.com>
On 12/14/2018 1:29 PM, Clement Moyroud wrote:
> My group at work is migrating a CVS repo to Git. The biggest issue we
> face so far is the performance of git blame, especially compared to
> CVS on the same file. One file especially causes us trouble: it's a
> 30k lines file with 25 years of history in 3k+ commits. The complete
> repo has 200k+ commits over that same period of time.
I think the 30k lines is the bigger issue than the 200k+ commits. I'm
not terribly familiar with the blame code, though.
> Currently, 'cvs annotate' takes 2.7 seconds, while 'git blame'
> (without -M nor -C) takes 145s.
>
> I tried using the commit-graph with the Bloom filter, per
> https://public-inbox.org/git/61559c5b-546e-d61b-d2e1-68de692f5972@gmail.com/.
Thanks for the interest in this prototype feature. Sorry that it doesn't
appear to help you in this case. It should definitely be a follow-up
when that feature gets polished to production-quality.
> Looking at the blame code, it does not seem to be able to use the
> commit graph, so I tried the same rev-list command from the e-mail,
> using my own file:
> > GIT_TRACE_BLOOM_FILTER=2 GIT_USE_POC_BLOOM_FILTER=y
> /path/to/git rev-list --count --full-history HEAD -- important/file.C
> 3576
>
Please double-check that you have the 'core.commitGraph' config setting
enabled, or you will not read the commit-graph at run-time:
git config core.commitGraph true
I see that the commit introducing GIT_TRACE_BLOOM_FILTER [1] does
nothing if the commit-graph is not loaded.
Thanks,
-Stolee
[1]
https://github.com/derrickstolee/git/commit/adc469894b755512c9d02f099700ead2a7a78377
next prev parent reply other threads:[~2018-12-14 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 18:29 Git blame performance on files with a lot of history Clement Moyroud
2018-12-14 19:10 ` Bryan Turner
2018-12-17 20:43 ` Clement Moyroud
2018-12-14 21:31 ` Derrick Stolee [this message]
2018-12-17 20:59 ` Clement Moyroud
2018-12-14 22:48 ` Ævar Arnfjörð Bjarmason
2018-12-17 20:30 ` Clement Moyroud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f3e7b11-19ef-cc2f-3bd4-e03d9ba8dc91@gmail.com \
--to=stolee@gmail.com \
--cc=clement.moyroud@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).