From: Derrick Stolee <stolee@gmail.com>
To: "René Scharfe" <l.s.r@web.de>, "Git Mailing List" <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] refs: pass NULL to refs_read_ref_full() because object ID is not needed
Date: Wed, 11 Dec 2019 14:01:49 -0500 [thread overview]
Message-ID: <3f39d0f8-adfb-5f25-a724-f37f26904fa6@gmail.com> (raw)
In-Reply-To: <a762958e-324b-f9a5-96e4-fab0b4b91df8@web.de>
On 12/11/2019 1:46 PM, René Scharfe wrote:
> refs_read_ref_full() wraps refs_resolve_ref_unsafe(), which handles a
> NULL oid pointer of callers not interested in the resolved object ID.
> Pass NULL from files_copy_or_rename_ref() to clarify that it is one
> such caller.
I suppose this could have been grouped/threaded with the other
similar patch, but still correct. Thanks!
-Stolee
prev parent reply other threads:[~2019-12-11 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 18:46 [PATCH] refs: pass NULL to refs_read_ref_full() because object ID is not needed René Scharfe
2019-12-11 19:01 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f39d0f8-adfb-5f25-a724-f37f26904fa6@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).