From: Derrick Stolee <email@example.com> To: Jeff King <firstname.lastname@example.org>, email@example.com Cc: Yiyuan guo <firstname.lastname@example.org> Subject: Re: [PATCH 3/5] pack-objects: clamp negative window size to 0 Date: Mon, 3 May 2021 08:10:24 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <YI1fubjvQQlrPz9D@coredump.intra.peff.net> On 5/1/2021 10:03 AM, Jeff King wrote: > A negative window size makes no sense, and the code in find_deltas() is > not prepared to handle it. If you pass "-1", for example, we end up > generate a 0-length array of "struct unpacked", but our loop assumes it > has at least one entry in it (and we end up reading garbage memory). > > We could complain to the user about this, but it's more forgiving to > just clamp it to 0, which means "do not find any deltas at all". The > 0-case is already tested earlier in the script, so we'll make sure this > does the same thing. This seems like a reasonable approach. It takes existing "undefined" behavior and turns it into well-understood, "defined" behavior. Thanks, -Stolee
next prev parent reply other threads:[~2021-05-03 12:10 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-01 14:02 [PATCH 0/5] pack-objects: better handling of negative options Jeff King 2021-05-01 14:02 ` [PATCH 1/5] t5300: modernize basic tests Jeff King 2021-05-03 5:27 ` Junio C Hamano 2021-05-03 14:53 ` Jeff King 2021-05-01 14:03 ` [PATCH 2/5] t5300: check that we produced expected number of deltas Jeff King 2021-05-01 14:03 ` [PATCH 3/5] pack-objects: clamp negative window size to 0 Jeff King 2021-05-03 12:10 ` Derrick Stolee [this message] 2021-05-03 14:55 ` Jeff King 2021-05-04 18:47 ` René Scharfe 2021-05-04 21:38 ` Jeff King 2021-05-05 11:53 ` Ævar Arnfjörð Bjarmason 2021-05-05 16:19 ` René Scharfe 2021-05-01 14:04 ` [PATCH 4/5] t5316: check behavior of pack-objects --depth=0 Jeff King 2021-05-01 14:04 ` [PATCH 5/5] pack-objects: clamp negative depth to 0 Jeff King 2021-05-03 12:11 ` Derrick Stolee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 3/5] pack-objects: clamp negative window size to 0' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).