From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 4F84E1F4B5 for ; Thu, 21 Nov 2019 00:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbfKUAqa (ORCPT ); Wed, 20 Nov 2019 19:46:30 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46805 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbfKUAqa (ORCPT ); Wed, 20 Nov 2019 19:46:30 -0500 Received: by mail-pl1-f193.google.com with SMTP id l4so660386plt.13 for ; Wed, 20 Nov 2019 16:46:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tPW7/8SMl6017Q/IMECZIjQvVVKketRz/lQXBlisQiw=; b=EkaH5DKujJU5RIXdC/+1uE4p0R6TBWqV4gaZGQLDWJntrNGo5kG6iHaCZP4ZWgPoQT 1FmsQhXPTW9tAhut2QNjUk6cGRexhHBcCzOHJmjfdkHaPIg96H/3/PVVFWqRIKCn14BA 0YIvR2wLIZgl3ERKdYp6Hq7qkCCSpCwtcm2/SFWSFfmzcbbCYUDkjDSJlMVoI8rkH6hT OiezP5Wk8KnU8PYtbbL2ndK0OvS4ZbJz60FztOSXt1ZY1HOHsh3/Nf4le92wAwcRZeRT ZK/Zw9sU5jZt9lcS8y7up5Uss8CLuefj4m69upQSQbn0fOoQLMwnC7nsor+O+R6OzUt9 c+vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tPW7/8SMl6017Q/IMECZIjQvVVKketRz/lQXBlisQiw=; b=G5fWgKUvYHsiUdFpsJW5Bn/WTarvl8w8d36jwylqX1bULgjB6NVEiv6mOijCid7Bru F/Rf/qhuVWDz1rRbeKRngMkIvvTUFcfHh2aBgNyu8WpvlX1jbAtWpP5AmP5OGmXrAQNu Pvu0sVX8OkwBSUyj4mSmB0gLk627vc9LmEp+l1OAsIuJgn08EvefvDun8sFtn54wQWYB EamjnSn+QZdC/prrGjrPOu0uhTYXWeDXKmq26sqTSSi948rWhVZx9Uv5GGipiyOVavb7 NIslLdCRNksFjl25zXiswZyaSZDK6DSg1UI9vAhW9Ad5B63NdMLxGlrIZ0Wq39K4EIyb D3Sg== X-Gm-Message-State: APjAAAWoakQCKHDNO9teZJQko+8F9Hid6Frw0THUYeYgwqvEbDDdDJbi eB+dE/OOGdxfsuG65BISzOOEs89w X-Google-Smtp-Source: APXvYqzYXnPMl7ykQdQ9gKW6h0noAWfgiUpf9gb8b+++oode4xfCfbhrk3vQbz+O3MNPdzcHFY1TXw== X-Received: by 2002:a17:90a:4fe6:: with SMTP id q93mr7606446pjh.88.1574297188949; Wed, 20 Nov 2019 16:46:28 -0800 (PST) Received: from generichostname ([204.14.239.83]) by smtp.gmail.com with ESMTPSA id y6sm614546pfm.12.2019.11.20.16.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2019 16:46:28 -0800 (PST) Date: Wed, 20 Nov 2019 16:46:26 -0800 From: Denton Liu To: Git Mailing List Cc: Eric Sunshine , Junio C Hamano , Jeff King Subject: [PATCH v2 17/21] t7700: drop redirections to /dev/null Message-ID: <3cc6e4455cd55ff5d03595f6c348ae80268497a6.1574296987.git.liu.denton@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Since output is silenced when running without `-v` and debugging output is useful with `-v`, remove redirections to /dev/null as it is not useful. In one case where the output of stdout is consumed, redirect the output of test_commit to stderr. Signed-off-by: Denton Liu --- t/t7700-repack.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh index 4e855bc21b..e1a689d6a9 100755 --- a/t/t7700-repack.sh +++ b/t/t7700-repack.sh @@ -5,7 +5,7 @@ test_description='git repack works correctly' . ./test-lib.sh commit_and_pack() { - test_commit "$@" >/dev/null && + test_commit "$@" 1>&2 && SHA1=$(git pack-objects --all --unpacked --incremental .git/objects/pack/pack /dev/null && + git pack-objects pack && # The second pack will contain the excluded object packsha1=$(git rev-list --objects --all | grep file2 | git pack-objects pack) && @@ -235,7 +235,7 @@ test_expect_success 'incremental repack does not complain' ' test_expect_success 'bitmaps can be disabled on bare repos' ' git -c repack.writeBitmaps=false -C bare.git repack -ad && - bitmap=$(ls bare.git/objects/pack/*.bitmap 2>/dev/null || :) && + bitmap=$(ls bare.git/objects/pack/*.bitmap || :) && test -z "$bitmap" ' -- 2.24.0.450.g7a9a4598a9