From: "Kyle J. McKay" <mackyle@gmail.com>
To: git@vger.kernel.org
Cc: "David Aguilar" <davvid@gmail.com>, "Petr Baudis" <pasky@ucw.cz>,
"Junio C Hamano" <gitster@pobox.com>,
"Richard Hartmann" <richih.mailinglist@gmail.com>,
"Jeff King" <peff@peff.net>,
"Daniel Knittl-Frank" <knittl89@googlemail.com>,
"Jan Krüger" <jk@jk.gs>, "Alejandro Mery" <amery@geeks.cl>,
"Aaron Schrab" <aaron@schrab.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: [PATCH v8 0/4] config: add support for http.<url>.* settings
Date: Mon, 22 Jul 2013 05:56:40 -0700 [thread overview]
Message-ID: <3c7fc982841069ce79faf227e007815@f74d39fa044aa309eaea14b9f57fe79> (raw)
NOTE: This patch requires the following preparatory change:
f1ff763 http.c: fix parsing of http.sslCertPasswordProtected variable
which is currently in pu.
This patch series adds support for http.<url>.* settings. The patch is
organized as a series of improvements on the functionality:
1/4 - adds basic textual matching support
2/4 - adds URL normalization before matching
3/4 - adds a test for the URL normalization function
4/4 - adds any user matching
With-Feedback-From-jh: Junio C Hamano <gitster@pobox.com>
Differences from v7:
1/4 - No changes since v7's 1/4
2/4 - No changes since v7's 2/4
3/4 - Updated from v7's 3/4:
* Add a binary attribute for the url-* files (feedback-jh)
* Make test-url-normalize.c able to run http_options (feedback-jh)
* Add additional tests and corresponding config files (as t/t5200/config-*)
* Remove extraneous comment from t5200-url-normalize.sh (feedback-jh)
4/4 - Updated from v7's 4/4:
* Update http.<url>.* documentation with another example (feedback-jh)
* Add another url normalization config test to match the new example
Applicable comments from earlier cover:
To better support matching URLs that are equivalent but spelled differently, a
url_normalize function has been added. Currently this patch leaves it in
http.c as http_options_url_normalize as I am unclear whether it should go into
url.{h,c} at this time since only http.c uses it.
Since the url_normalize function's behavior is non-trivial, it is presented as
a separate patch on top of the basic http.<url>.* settings support. A new test
for it has also been included as a separate patch. I am unclear on the proper
number for this test, but have gone ahead and put it with the other http tests
since this patch series places the url_normalize function into http.c.
Kyle J. McKay (4):
config: add support for http.<url>.* settings
config: improve support for http.<url>.* settings
tests: add new test for the url_normalize function
config: allow http.<url>.* any user matching
.gitignore | 1 +
Documentation/config.txt | 25 ++
Makefile | 5 +
http.c | 666 +++++++++++++++++++++++++++++++++++++++++++++--
t/.gitattributes | 1 +
t/t5200-url-normalize.sh | 199 ++++++++++++++
t/t5200/README | 18 ++
t/t5200/config-1 | 8 +
t/t5200/config-2 | 3 +
t/t5200/config-3 | 4 +
t/t5200/url-1 | Bin 0 -> 20 bytes
t/t5200/url-10 | Bin 0 -> 23 bytes
t/t5200/url-11 | Bin 0 -> 25 bytes
t/t5200/url-2 | Bin 0 -> 20 bytes
t/t5200/url-3 | Bin 0 -> 23 bytes
t/t5200/url-4 | Bin 0 -> 23 bytes
t/t5200/url-5 | Bin 0 -> 23 bytes
t/t5200/url-6 | Bin 0 -> 23 bytes
t/t5200/url-7 | Bin 0 -> 23 bytes
t/t5200/url-8 | Bin 0 -> 23 bytes
t/t5200/url-9 | Bin 0 -> 23 bytes
test-url-normalize.c | 132 ++++++++++
22 files changed, 1045 insertions(+), 17 deletions(-)
create mode 100755 t/t5200-url-normalize.sh
create mode 100644 t/t5200/README
create mode 100644 t/t5200/config-1
create mode 100644 t/t5200/config-2
create mode 100644 t/t5200/config-3
create mode 100644 t/t5200/url-1
create mode 100644 t/t5200/url-10
create mode 100644 t/t5200/url-11
create mode 100644 t/t5200/url-2
create mode 100644 t/t5200/url-3
create mode 100644 t/t5200/url-4
create mode 100644 t/t5200/url-5
create mode 100644 t/t5200/url-6
create mode 100644 t/t5200/url-7
create mode 100644 t/t5200/url-8
create mode 100644 t/t5200/url-9
create mode 100644 test-url-normalize.c
--
1.8.3
next reply other threads:[~2013-07-22 12:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 12:56 Kyle J. McKay [this message]
2013-07-22 12:56 ` [PATCH v8 1/4] config: add support for http.<url>.* settings Kyle J. McKay
2013-07-24 7:12 ` Jeff King
2013-07-22 12:56 ` [PATCH v8 2/4] config: improve " Kyle J. McKay
2013-07-22 12:56 ` [PATCH v8 3/4] tests: add new test for the url_normalize function Kyle J. McKay
2013-07-24 6:59 ` Jeff King
2013-07-24 17:14 ` Junio C Hamano
2013-07-24 18:43 ` Kyle J. McKay
2013-07-24 19:01 ` Kyle J. McKay
2013-07-24 19:03 ` Jeff King
2013-07-22 12:56 ` [PATCH v8 4/4] config: allow http.<url>.* any user matching Kyle J. McKay
2013-07-22 18:00 ` Junio C Hamano
2013-07-22 20:24 ` Kyle J. McKay
2013-07-22 21:51 ` Junio C Hamano
2013-07-22 22:18 ` Kyle J. McKay
2013-07-22 22:34 ` Junio C Hamano
2013-07-24 6:42 ` Jeff King
2013-07-24 15:00 ` Junio C Hamano
2013-07-24 6:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c7fc982841069ce79faf227e007815@f74d39fa044aa309eaea14b9f57fe79 \
--to=mackyle@gmail.com \
--cc=aaron@schrab.com \
--cc=amery@geeks.cl \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jk@jk.gs \
--cc=knittl89@googlemail.com \
--cc=pasky@ucw.cz \
--cc=peff@peff.net \
--cc=richih.mailinglist@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).