From: ch <cr@onlinehome.de>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Martin von Zweigbergk" <martinvonz@gmail.com>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Git List" <git@vger.kernel.org>, "Jeff King" <peff@peff.net>
Subject: Re: [REGRESSION] gitk can't be run from non-worktree folders
Date: Thu, 2 Apr 2020 15:40:42 +0200 [thread overview]
Message-ID: <3c1a3e23-cf52-48cc-e9b6-f80642ca67ac@onlinehome.de> (raw)
In-Reply-To: <CAPig+cTixT9JYDPn-umKdQLtTm5byA1wwmvVY1ryuh+hv2=6MQ@mail.gmail.com>
I haven't actually bisected it but the change possibly also broke
git-gui-browser on bare repositories.
The follow patch seems to fix the issue. As I stated in my original bug report
I'm using Git for Windows so maybe it does not apply cleanly on upstream Git.
-- >8 --
--- git-gui.tcl 2020-03-23 12:22:36.000000000 +0100
+++ git-gui-fixed.tcl 2020-04-01 17:35:26.092223600 +0200
@@ -1286,7 +1286,7 @@
if { [is_Cygwin] } {
catch {set _gitworktree [exec cygpath --windows [git rev-parse --show-toplevel]]}
} else {
- set _gitworktree [git rev-parse --show-toplevel]
+ catch {set _gitworktree [git rev-parse --show-toplevel]}
}
} else {
# try to set work tree from environment, core.worktree or use
-- >8 --
On 23.01.2020 17:36, Eric Sunshine wrote:
> It's a new regression introduced by 2d92ab32fd (rev-parse: make
> --show-toplevel without a worktree an error, 2019-11-19), as far as I
> can tell. I have many times used gitk on bare repositories as an
> interactive replacement for git-log, so this is a unfortunate bit of
> fallout from that change. That's not to say that 2d92ab32fd should be
> reverted, though... perhaps gitk itself needs a bit of a fix.
>
next prev parent reply other threads:[~2020-04-02 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 16:04 [REGRESSION] gitk can't be run from non-worktree folders ch
2020-01-23 16:31 ` SZEDER Gábor
2020-01-23 16:36 ` Eric Sunshine
2020-01-23 17:04 ` SZEDER Gábor
2020-01-23 17:46 ` SZEDER Gábor
2020-01-23 19:02 ` Junio C Hamano
2020-01-23 19:20 ` [PATCH] gitk: to run in a bare repository (was: gitk can't be run from non-worktree folders) Junio C Hamano
2020-01-23 19:26 ` Eric Sunshine
2020-01-23 19:27 ` Jeff King
2020-03-30 15:20 ` ch
2020-10-11 5:08 ` Eric Sunshine
2020-10-13 14:25 ` [PATCH] gitk: to run in a bare repository ch
2020-10-13 15:31 ` Pratyush Yadav
2020-04-02 13:40 ` ch [this message]
2020-04-02 17:47 ` [REGRESSION] gitk can't be run from non-worktree folders Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c1a3e23-cf52-48cc-e9b6-f80642ca67ac@onlinehome.de \
--to=cr@onlinehome.de \
--cc=git@vger.kernel.org \
--cc=martinvonz@gmail.com \
--cc=paulus@ozlabs.org \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).