git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* Is git am supposed to decode MIME?
@ 2017-10-04  8:44 Florian Weimer
  2017-10-04  9:25 ` Jeff King
  2017-10-04 10:10 ` Junio C Hamano
  0 siblings, 2 replies; 4+ messages in thread
From: Florian Weimer @ 2017-10-04  8:44 UTC (permalink / raw)
  To: git

The git am documentation talks about “mailboxes”.  I suppose these 
contain messages in Internet Mail syntax.  Is git am supposed to decode 
MIME?

I'm asking because I have a message whose body is encoded as 
quoted-printable, but git am does not parse the patch contained in it.

If git am is supposed to deal with this, I'll dig deeper and try to 
figure out where things go wrong.

Thanks,
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Is git am supposed to decode MIME?
  2017-10-04  8:44 Is git am supposed to decode MIME? Florian Weimer
@ 2017-10-04  9:25 ` Jeff King
  2017-10-12 13:20   ` Florian Weimer
  2017-10-04 10:10 ` Junio C Hamano
  1 sibling, 1 reply; 4+ messages in thread
From: Jeff King @ 2017-10-04  9:25 UTC (permalink / raw)
  To: Florian Weimer; +Cc: git

On Wed, Oct 04, 2017 at 10:44:31AM +0200, Florian Weimer wrote:

> The git am documentation talks about “mailboxes”.  I suppose these contain
> messages in Internet Mail syntax.  Is git am supposed to decode MIME?
> 
> I'm asking because I have a message whose body is encoded as
> quoted-printable, but git am does not parse the patch contained in it.
> 
> If git am is supposed to deal with this, I'll dig deeper and try to figure
> out where things go wrong.

Yes, it should. I just double-checked with the toy patch patch below,
and it correctly extracted the quoted-printable from the commit message
and patch, as well as in the headers.

-- >8 --
From peff@peff.net Wed Oct  4 05:21:57 2017
Date: Wed, 4 Oct 2017 05:21:55 -0400
From: =?utf-8?Q?=C3=81ccented N=C3=A1me?= <peff@peff.net>
To: Jeff King <peff@peff.net>
Subject: [PATCH] add 8bit content
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

This commit message also has s=C3=B3me 8-bit characters which
will need qp-encoding.

Signed-off-by: =C3=81ccented N=C3=A1me <peff@peff.net>
---
 file | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/file b/file
index d95f3ad..d39c7fc 100644
--- a/file
+++ b/file
@@ -1 +1 @@
-content
+8-bit c=C3=B3ntent
--=20
2.14.2.1117.g65a3442612


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Is git am supposed to decode MIME?
  2017-10-04  8:44 Is git am supposed to decode MIME? Florian Weimer
  2017-10-04  9:25 ` Jeff King
@ 2017-10-04 10:10 ` Junio C Hamano
  1 sibling, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2017-10-04 10:10 UTC (permalink / raw)
  To: Florian Weimer; +Cc: git

Florian Weimer <fweimer@redhat.com> writes:

> The git am documentation talks about “mailboxes”.  I suppose these
> contain messages in Internet Mail syntax.  Is git am supposed to
> decode MIME?
>
> I'm asking because I have a message whose body is encoded as
> quoted-printable, but git am does not parse the patch contained in it.
>
> If git am is supposed to deal with this, I'll dig deeper and try to
> figure out where things go wrong.

The code to check should be in <mailinfo.c>.  As its comment says,
the code was not designed to be a full MIME parser--we just have a
code that (empirically) works in practice on messages produced when
a patch is attached to a message via popular MUAs, not written from
the MIME RFC spec.

Thanks for your interest in making the world a better place ;-)
Very much appreciated.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Is git am supposed to decode MIME?
  2017-10-04  9:25 ` Jeff King
@ 2017-10-12 13:20   ` Florian Weimer
  0 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer @ 2017-10-12 13:20 UTC (permalink / raw)
  To: Jeff King; +Cc: git

On 10/04/2017 11:25 AM, Jeff King wrote:
> On Wed, Oct 04, 2017 at 10:44:31AM +0200, Florian Weimer wrote:
> 
>> The git am documentation talks about “mailboxes”.  I suppose these contain
>> messages in Internet Mail syntax.  Is git am supposed to decode MIME?
>>
>> I'm asking because I have a message whose body is encoded as
>> quoted-printable, but git am does not parse the patch contained in it.
>>
>> If git am is supposed to deal with this, I'll dig deeper and try to figure
>> out where things go wrong.
> 
> Yes, it should. I just double-checked with the toy patch patch below,
> and it correctly extracted the quoted-printable from the commit message
> and patch, as well as in the headers.

It took me a while, but I know think the message is simply corrupted. 
It's encoded with quoted-printable, and that looks correct, but it ends 
with:

@@ -5137,11 +5114,13 @@ __libc_mallopt (int param_number, int value)
    if (__malloc_initialized < 0)
      ptmalloc_init ();
    __libc_lock_lock (av->mutex);
-  /* Ensure initialization/consolidation */
-  malloc_consolidate (av);
=20
    LIBC_PROBE (memory_mallopt, 2, param_number, value);
=20
+  /* We must consolidate main arena before changing max_fast
+     (see definition of set_max_fast).  */
+  malloc_consolidate (av);
+
    switch (param_number)
      {
      case M_MXFAST:=

The “=” masks the final newline, and that doesn't decode into a valid 
diff hunk.  The file being patched continues after that, so it's not 
even the “\ No newline at end of file” case.

So in short, there is no Git bug here, and I just failed to interpret 
the “git am” diagnostics correctly:

Applying: Improve malloc initialization sequence
error: corrupt patch at line 342
Patch failed at 0001 Improve malloc initialization sequence
The copy of the patch that failed is found in: .git/rebase-apply/patch

Line 342 refers to the file in .git/rebase-apply/patch, not the original 
input, and it took me a while to figure that out.

Thanks,
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04  8:44 Is git am supposed to decode MIME? Florian Weimer
2017-10-04  9:25 ` Jeff King
2017-10-12 13:20   ` Florian Weimer
2017-10-04 10:10 ` Junio C Hamano

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox