From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C1B7A1F466 for ; Fri, 17 Jan 2020 15:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728895AbgAQPU2 (ORCPT ); Fri, 17 Jan 2020 10:20:28 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:42122 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728739AbgAQPU2 (ORCPT ); Fri, 17 Jan 2020 10:20:28 -0500 Received: by mail-qk1-f195.google.com with SMTP id z14so22985928qkg.9 for ; Fri, 17 Jan 2020 07:20:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zicKP2mTygS71vvhzpA5ErpSLvdM6IWv+CsGCmxp4/c=; b=DIu75gBsGeKx+p3fdxcSV2TjM3asOqykjhB/lVfSjsU9Wzw/l4fyAifRHYqvKW7BQz rtQ1IWL3y4CZArqIzeV7q8mX9TZq72E7D+zEzYrKy1NEzE/5J2+W+wSbmn9k9oLeOqDk T258wUSun7MPYgAb8jRe6Xa0oSWRswKkxBVuFHi/CAImd+s5NYiTRqw9a6iIbLXH/Ty6 4elcO96pQ7JYZkz3vwpoqxMQvnrfeKVvD/jmjCLjy207tgRTRhx5l1NTnDRzqvEK0f17 mEMNespZ6oPHQb3hvC5q4o3piHrEy00JBSbz2MFl4NTndvD3bmBnioVp/bYpP6aPRHql QF3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zicKP2mTygS71vvhzpA5ErpSLvdM6IWv+CsGCmxp4/c=; b=NOxlmwXOPlx1e4Xj+YFjfEdnHwYi6fk2xNm+zAnrU/FekOaAzOf4BrpsnXtj0eSxHP VDDbxXShmkVxZQFqR/gtPZyS3iqrv5HpZD/RCaGaLfjCoxj1N5qstlyuG4zsTXW/g8r3 gg/5/2HQgs7cehZTpDOW9n83oKQbTM4jzlH1wVpRsaXDYa8835WyM5SIW2k002BhN0Kh 0xU8jdbqQfACBfz2DGuaq0ejyxan4tBiKWam0+vXpXmAZpDvskCxt85nmDquoySCdsLO wNRyOx/pe5IlZwzZqgunCUUxmedDp6gFG/sphIIMOVkDrqcSDjJ0vj7U5VjMbj7K0Qno m4Ug== X-Gm-Message-State: APjAAAWWPjXaeJmQ11XZx7DN+J4hV83nPWsvvm8mRpaLLtO6yCv9utQV 8PBtdNChyAO8b7p9Di/Y3L8= X-Google-Smtp-Source: APXvYqyZwUyzdH1s34vs60jO/71GTRbjDbuQXnbHX2F8b6EkG/c2HQGWVeBPP1yPkDMeNAYKoLH0jg== X-Received: by 2002:a37:4b93:: with SMTP id y141mr40387373qka.205.1579274427594; Fri, 17 Jan 2020 07:20:27 -0800 (PST) Received: from ?IPv6:2001:4898:6808:13e:64d0:3701:c4c7:2368? ([2001:4898:a800:1012:1604:3701:c4c7:2368]) by smtp.gmail.com with ESMTPSA id o6sm11661762qkk.53.2020.01.17.07.20.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2020 07:20:26 -0800 (PST) Subject: Re: [PATCH v3 1/4] clean: demonstrate a bug with pathspecs To: Derrick Stolee via GitGitGadget , git@vger.kernel.org Cc: Jeff King , Johannes Schindelin , Derrick Stolee , Kevin.Willford@microsoft.com, Kyle Meyer , Jonathan Nieder , Elijah Newren References: <9efed585ef7a1c09ed62998882236e7dbb58383a.1579206117.git.gitgitgadget@gmail.com> From: Derrick Stolee Message-ID: <37815f50-35df-ef02-4def-ad857fd55520@gmail.com> Date: Fri, 17 Jan 2020 10:20:26 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Thunderbird/72.0 MIME-Version: 1.0 In-Reply-To: <9efed585ef7a1c09ed62998882236e7dbb58383a.1579206117.git.gitgitgadget@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 1/16/2020 3:21 PM, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > b9670c1f5e (dir: fix checks on common prefix directory, 2019-12-19) Thanks for fixing my typo here. > modified the way pathspecs are handled when handling a directory > during "git clean -f ". While this improved the behavior for > known test breakages, it also regressed in how the clean command > handles cleaning a specified file. > > Add a test case that demonstrates this behavior. This test passes > before b9670c1f5e then fails after. > > Helped-by: Kevin Willford > Signed-off-by: Derrick Stolee > Reviewed-by: Elijah Newren Do we need your sign-off here, too? -Stolee