git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: KES <kes-kes@yandex.ru>
To: git@vger.kernel.org
Subject: Feature request: Reduce amount of diff in patch
Date: Tue, 28 Nov 2017 18:09:30 +0200	[thread overview]
Message-ID: <372261511885370@web21o.yandex.ru> (raw)

Hi.

I get often patches which can be minimized:

@@ -60,11 +64,8 @@ sub _get_filter {
         address    =>  { -like => \[ '?',  "%$search%" ] },
         company    =>  { -like => \[ '?',  "%$search%" ] },
         country_code =>  { '=' => \[ 'UPPER(?)' => $search ] },
-    ]);
 
-    $users =  $users->search( $filter, {
-        prefetch => { Packages => { Ips => { Subnet => { Server => 'Locality' }}}},
-    });
+    ]);
 
 
     return $users;

This patch can be minimized to:

@@ -60,11 +64,8 @@ sub _get_filter {
         address    =>  { -like => \[ '?',  "%$search%" ] },
         company    =>  { -like => \[ '?',  "%$search%" ] },
         country_code =>  { '=' => \[ 'UPPER(?)' => $search ] },
     ]);
 
-    $users =  $users->search( $filter, {
-        prefetch => { Packages => { Ips => { Subnet => { Server => 'Locality' }}}},
-    });

 
     return $users;

May you please fix the git to generate minimized patches?

Thank you

             reply	other threads:[~2017-11-28 16:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 16:09 KES [this message]
2017-11-28 17:24 ` Feature request: Reduce amount of diff in patch Kaartic Sivaraam
2017-12-07 20:13 ` Stefan Beller
2017-12-07 20:28   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=372261511885370@web21o.yandex.ru \
    --to=kes-kes@yandex.ru \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).