From: "Chris Poucet via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Jerry Zhang" <jerry@skydio.com>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Chris Poucet" <poucet@google.com>,
"Christophe Poucet" <christophe.poucet@gmail.com>,
"Chris Poucet" <poucet@google.com>
Subject: [PATCH v2 10/10] evolve: add tests for the git-change command
Date: Wed, 05 Oct 2022 14:59:17 +0000 [thread overview]
Message-ID: <37042b58cda070bd562d7f64d654bd407e8572e4.1664981958.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1356.v2.git.1664981957.gitgitgadget@gmail.com>
From: Chris Poucet <poucet@google.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Chris Poucet <poucet@google.com>
---
t/t9990-changes.sh | 148 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 148 insertions(+)
create mode 100755 t/t9990-changes.sh
diff --git a/t/t9990-changes.sh b/t/t9990-changes.sh
new file mode 100755
index 00000000000..11fbd8ba49c
--- /dev/null
+++ b/t/t9990-changes.sh
@@ -0,0 +1,148 @@
+#!/bin/sh
+
+test_description='git change - low level meta-commit management'
+
+. ./test-lib.sh
+
+. "$TEST_DIRECTORY"/lib-rebase.sh
+
+test_expect_success 'setup commits and meta-commits' '
+ for c in one two three
+ do
+ test_commit $c &&
+ git change update --content $c >actual 2>err &&
+ echo "Created change metas/$c" >expect &&
+ test_cmp expect actual &&
+ test_must_be_empty err &&
+ test_cmp_rev refs/metas/$c $c || return 1
+ done
+'
+
+# Check a meta-commit has the correct parents Call with the object
+# name of the meta-commit followed by pairs of type and parent
+check_meta_commit () {
+ name=$1
+ shift
+ while test $# -gt 0
+ do
+ printf '%s %s\n' $1 $(git rev-parse --verify $2)
+ shift
+ shift
+ done | sort >expect
+ git cat-file commit $name >metacommit &&
+ # commit body should consist of parent-type
+ types="$(sed -n '/^$/ {
+ :loop
+ n
+ s/^parent-type //
+ p
+ b loop
+ }' metacommit)" &&
+ while read key value
+ do
+ # TODO: don't sort the first parent
+ if test "$key" = "parent"
+ then
+ type="${types%% *}"
+ test -n "$type" || return 1
+ printf '%s %s\n' $type $value
+ types="${types#?}"
+ types="${types# }"
+ elif test "$key" = "tree"
+ then
+ test_cmp_rev "$value" $EMPTY_TREE || return 1
+ elif test -z "$key"
+ then
+ # only parse commit headers
+ break
+ fi
+ done <metacommit >actual-unsorted &&
+ test -z "$types" &&
+ sort >actual <actual-unsorted &&
+ test_cmp expect actual
+}
+
+test_expect_success 'update meta-commits after rebase' '
+ (
+ set_fake_editor &&
+ FAKE_AMEND=edited &&
+ FAKE_LINES="reword 1 pick 2 fixup 3" &&
+ export FAKE_AMEND FAKE_LINES &&
+ git rebase -i --root
+ ) &&
+
+ # update meta-commits
+ git change update --replace tags/one --content HEAD~1 >out 2>err &&
+ echo "Updated change metas/one" >expect &&
+ test_cmp expect out &&
+ test_must_be_empty err &&
+ git change update --replace tags/two --content HEAD@{2} &&
+ oid=$(git rev-parse --verify metas/two) &&
+ git change update --replace HEAD@{2} --replace tags/three \
+ --content HEAD &&
+
+ # check meta-commits
+ check_meta_commit metas/one c HEAD~1 r tags/one &&
+ check_meta_commit $oid c HEAD@{2} r tags/two &&
+ # NB this checks that "git change update" uses the meta-commit ($oid)
+ # corresponding to the replaces commit (HEAD@2 above) given on the
+ # commandline.
+ check_meta_commit metas/two c HEAD r $oid r tags/three &&
+ check_meta_commit metas/three c HEAD r $oid r tags/three
+'
+
+reset_meta_commits () {
+ for c in one two three
+ do
+ echo "update refs/metas/$c refs/tags/$c^0"
+ done | git update-ref --stdin
+}
+
+test_expect_success 'override change name' '
+ # TODO: builtin/change.c expects --change to be the full refname,
+ # ideally it would prepend refs/metas to the string given by the
+ # user.
+ git change update --change refs/metas/another-one --content one &&
+ test_cmp_rev metas/another-one one
+'
+
+test_expect_success 'non-fast forward meta-commit update refused' '
+ test_must_fail git change update --change refs/metas/one --content two \
+ >out 2>err &&
+ echo "error: non-fast-forward update to ${SQ}refs/metas/one${SQ}" \
+ >expect &&
+ test_cmp expect err &&
+ test_must_be_empty out
+'
+
+test_expect_success 'forced non-fast forward update succeeds' '
+ git change update --change refs/metas/one --content two --force \
+ >out 2>err &&
+ echo "Updated change metas/one" >expect &&
+ test_cmp expect out &&
+ test_must_be_empty err
+'
+
+test_expect_success 'list changes' '
+ cat >expect <<-\EOF &&
+metas/another-one
+metas/one
+metas/three
+metas/two
+EOF
+ git change list >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'delete change' '
+ git change delete metas/one &&
+ cat >expect <<-\EOF &&
+metas/another-one
+metas/three
+metas/two
+EOF
+ git change list >actual &&
+ test_cmp expect actual
+'
+
+test_done
--
gitgitgadget
next prev parent reply other threads:[~2022-10-05 15:02 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 18:55 [PATCH 00/10] Add the Git Change command Christophe Poucet via GitGitGadget
2022-09-23 18:55 ` [PATCH 01/10] technical doc: add a design doc for the evolve command Stefan Xenos via GitGitGadget
2022-09-23 19:59 ` Jerry Zhang
2022-09-28 21:26 ` Junio C Hamano
2022-09-28 22:20 ` Junio C Hamano
2022-09-29 9:17 ` Phillip Wood
2022-09-29 19:57 ` Jonathan Tan
2022-09-23 18:55 ` [PATCH 02/10] sha1-array: implement oid_array_readonly_contains Chris Poucet via GitGitGadget
2022-09-26 13:08 ` Phillip Wood
2022-09-23 18:55 ` [PATCH 03/10] ref-filter: add the metas namespace to ref-filter Chris Poucet via GitGitGadget
2022-09-26 13:13 ` Phillip Wood
2022-10-04 9:50 ` Chris P
2022-09-23 18:55 ` [PATCH 04/10] evolve: add support for parsing metacommits Stefan Xenos via GitGitGadget
2022-09-26 13:27 ` Phillip Wood
2022-10-04 11:21 ` Chris P
2022-10-04 14:10 ` Phillip Wood
2022-09-23 18:55 ` [PATCH 05/10] evolve: add the change-table structure Stefan Xenos via GitGitGadget
2022-09-27 13:27 ` Phillip Wood
2022-09-27 13:50 ` Ævar Arnfjörð Bjarmason
2022-09-27 14:13 ` Phillip Wood
2022-09-27 15:28 ` Ævar Arnfjörð Bjarmason
2022-09-28 14:33 ` Phillip Wood
2022-09-28 15:14 ` Ævar Arnfjörð Bjarmason
2022-09-28 15:59 ` Junio C Hamano
2022-09-27 14:18 ` Phillip Wood
2022-10-04 14:48 ` Chris P
2022-09-23 18:55 ` [PATCH 06/10] evolve: add support for writing metacommits Stefan Xenos via GitGitGadget
2022-09-28 14:27 ` Phillip Wood
2022-10-05 9:40 ` Chris P
2022-10-05 11:09 ` Phillip Wood
2022-09-23 18:55 ` [PATCH 07/10] evolve: implement the git change command Stefan Xenos via GitGitGadget
2022-09-25 9:10 ` Phillip Wood
2022-09-26 8:23 ` Ævar Arnfjörð Bjarmason
2022-09-26 8:25 ` Ævar Arnfjörð Bjarmason
2022-10-05 12:30 ` Chris P
2022-09-23 18:55 ` [PATCH 08/10] evolve: add the git change list command Stefan Xenos via GitGitGadget
2022-09-23 18:55 ` [PATCH 09/10] evolve: add delete command Chris Poucet via GitGitGadget
2022-09-26 8:38 ` Ævar Arnfjörð Bjarmason
2022-09-26 9:10 ` Chris Poucet
2022-09-23 18:55 ` [PATCH 10/10] evolve: add documentation for `git change` Chris Poucet via GitGitGadget
2022-09-25 8:41 ` Phillip Wood
2022-09-25 8:39 ` [PATCH 00/10] Add the Git Change command Phillip Wood
2022-10-04 9:33 ` Chris P
2022-10-04 14:24 ` Phillip Wood
2022-10-04 15:19 ` Chris P
2022-10-04 15:55 ` Chris P
2022-10-04 16:00 ` Phillip Wood
2022-10-04 15:57 ` Phillip Wood
2022-10-05 14:59 ` [PATCH v2 00/10] RFC: Git Evolve / Change Christophe Poucet via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 01/10] technical doc: add a design doc for the evolve command Stefan Xenos via GitGitGadget
2022-10-05 15:16 ` Chris Poucet
2022-10-06 20:53 ` Glen Choo
2022-10-10 19:35 ` Victoria Dye
2022-10-11 8:59 ` Phillip Wood
2022-10-11 16:59 ` Victoria Dye
2022-10-12 19:19 ` Phillip Wood
2022-10-05 14:59 ` [PATCH v2 02/10] sha1-array: implement oid_array_readonly_contains Chris Poucet via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 03/10] ref-filter: add the metas namespace to ref-filter Chris Poucet via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 04/10] evolve: add support for parsing metacommits Stefan Xenos via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 05/10] evolve: add the change-table structure Stefan Xenos via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 06/10] evolve: add support for writing metacommits Stefan Xenos via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 07/10] evolve: implement the git change command Stefan Xenos via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 08/10] evolve: add delete command Chris Poucet via GitGitGadget
2022-10-05 14:59 ` [PATCH v2 09/10] evolve: add documentation for `git change` Chris Poucet via GitGitGadget
2022-10-05 14:59 ` Chris Poucet via GitGitGadget [this message]
2022-10-10 9:23 ` [PATCH v2 00/10] RFC: Git Evolve / Change Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37042b58cda070bd562d7f64d654bd407e8572e4.1664981958.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=avarab@gmail.com \
--cc=christophe.poucet@gmail.com \
--cc=git@vger.kernel.org \
--cc=jerry@skydio.com \
--cc=phillip.wood123@gmail.com \
--cc=poucet@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).