git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Phillip Wood <phillip.wood@talktalk.net>
To: Johannes Sixt <j6t@kdbg.org>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git: add -N as a short option for --no-pager
Date: Wed, 25 Apr 2018 10:21:33 +0100	[thread overview]
Message-ID: <36d622ac-f07d-7fd9-65dd-94f88b0e2f56@talktalk.net> (raw)
In-Reply-To: <d91e98a8-7801-a3de-3865-f0480e18ba0e@kdbg.org>

On 24/04/18 17:59, Johannes Sixt wrote:
> 
> In modern setups, less, the pager, uses alternate screen to show
> the content. When it is closed, it switches back to the original
> screen, and all content is gone.

Are you setting LESS explicitly in the environment?

 From the git config man page:
When the LESS environment variable is unset, Git sets it to FRX (if LESS 
environment variable is set, Git does not change it at all).

 From the less man page the X option:
Disables  sending the termcap initialization and deinitialization 
strings to the terminal.  This is sometimes desirable if the 
deinitialization string does something unnecessary, like clearing the 
screen.

So with the default setup the output should remain on the screen.

Best Wishes

Phillip


> It is not uncommon to request that the output remains visible in
> the terminal. For this, the option --no-pager can be used. But
> it is a bit cumbersome to type, even when command completion is
> available. Provide a short option, -N, to make the option easier
> accessible.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>   Documentation/git.txt | 3 ++-
>   git.c                 | 4 ++--
>   2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/git.txt b/Documentation/git.txt
> index 4767860e72..17b50b0dc6 100644
> --- a/Documentation/git.txt
> +++ b/Documentation/git.txt
> @@ -11,7 +11,7 @@ SYNOPSIS
>   [verse]
>   'git' [--version] [--help] [-C <path>] [-c <name>=<value>]
>       [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
> -    [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
> +    [-p|--paginate|-N|--no-pager] [--no-replace-objects] [--bare]
>       [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
>       [--super-prefix=<path>]
>       <command> [<args>]
> @@ -103,6 +103,7 @@ foo.bar= ...`) sets `foo.bar` to the empty string which `git config
>   	configuration options (see the "Configuration Mechanism" section
>   	below).
>   
> +-N::
>   --no-pager::
>   	Do not pipe Git output into a pager.
>   
> diff --git a/git.c b/git.c
> index ceaa58ef40..9e2d78f442 100644
> --- a/git.c
> +++ b/git.c
> @@ -7,7 +7,7 @@
>   const char git_usage_string[] =
>   	N_("git [--version] [--help] [-C <path>] [-c <name>=<value>]\n"
>   	   "           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]\n"
> -	   "           [-p | --paginate | --no-pager] [--no-replace-objects] [--bare]\n"
> +	   "           [-p | --paginate | -N | --no-pager] [--no-replace-objects] [--bare]\n"
>   	   "           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]\n"
>   	   "           <command> [<args>]");
>   
> @@ -81,7 +81,7 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
>   			exit(0);
>   		} else if (!strcmp(cmd, "-p") || !strcmp(cmd, "--paginate")) {
>   			use_pager = 1;
> -		} else if (!strcmp(cmd, "--no-pager")) {
> +		} else if (!strcmp(cmd, "-N") || !strcmp(cmd, "--no-pager")) {
>   			use_pager = 0;
>   			if (envchanged)
>   				*envchanged = 1;
> 


  parent reply	other threads:[~2018-04-25  9:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 16:59 [PATCH] git: add -N as a short option for --no-pager Johannes Sixt
2018-04-25  0:05 ` Junio C Hamano
2018-04-25  5:45   ` Beat Bolli <bbolli@ewanet.ch>
2018-04-25  6:25   ` Johannes Sixt
2018-04-25  7:41     ` Johannes Schindelin
2018-04-25 19:30       ` Johannes Sixt
2018-05-01 11:41     ` Kaartic Sivaraam
2018-04-25  9:21 ` Phillip Wood [this message]
2018-04-25 19:31   ` Johannes Sixt
2018-05-01 11:25     ` Kaartic Sivaraam
2018-05-03 17:15 ` [PATCH v2] git: add -P " Johannes Sixt
2018-05-03 20:06   ` Eric Sunshine
2018-05-04  5:43     ` Junio C Hamano
2018-12-21 12:04   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36d622ac-f07d-7fd9-65dd-94f88b0e2f56@talktalk.net \
    --to=phillip.wood@talktalk.net \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).