From: "Sean" <seanlkml@sympatico.ca>
To: "Junio C Hamano" <junkio@cox.net>
Cc: git@vger.kernel.org, "Linus Torvalds" <torvalds@osdl.org>
Subject: Re: [RFC] Renaming environment variables.
Date: Mon, 9 May 2005 17:04:38 -0400 (EDT) [thread overview]
Message-ID: <3677.10.10.10.24.1115672678.squirrel@linux1> (raw)
In-Reply-To: <7vhdhcxj0z.fsf_-_@assigned-by-dhcp.cox.net>
On Mon, May 9, 2005 4:05 pm, Junio C Hamano said:
> H. Peter Anvin mentioned that using SHA1_whatever as an
> environment variable name is not nice and we should instead use
> names starting with "GIT_" prefix to avoid conflicts.
>
> Here is a patch, requesting for comments.
Junio,
Look quite good; you made short work of that!
However I don't understand your gitenv_bc, wouldn't the following suffice?
char *gitenv_bc(const char *e)
{
int i;
char *val = getenv(e);
if (val)
return val;
for (i=0; i < sizeof(bc_name) / sizeof(bc_name[0]); ++i) {
if (!strcmp(e, bc_name[i].canonical)) {
if (val = getenv(bc_name[i].old))
warn_old_environment();
return val;
}
}
return NULL;
}
Cheers,
Sean
next prev parent reply other threads:[~2005-05-09 20:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 23:35 [PATCH] Introduce SHA1_FILE_DIRECTORIES Junio C Hamano
2005-05-07 0:20 ` Sean
2005-05-07 0:24 ` Junio C Hamano
2005-05-07 0:32 ` Sean
2005-05-07 6:31 ` Junio C Hamano
2005-05-07 19:51 ` Junio C Hamano
2005-05-09 13:33 ` H. Peter Anvin
2005-05-09 16:38 ` Junio C Hamano
2005-05-09 16:41 ` Sean
2005-05-09 18:03 ` H. Peter Anvin
2005-05-09 18:50 ` Junio C Hamano
2005-05-09 20:05 ` [RFC] Renaming environment variables Junio C Hamano
2005-05-09 20:15 ` Thomas Glanzmann
2005-05-10 0:32 ` Petr Baudis
2005-05-09 21:04 ` Sean [this message]
2005-05-09 23:08 ` Daniel Barkalow
2005-05-10 0:09 ` Junio C Hamano
2005-05-10 0:13 ` Petr Baudis
2005-05-10 0:22 ` Junio C Hamano
2005-05-10 0:27 ` Petr Baudis
2005-05-10 0:38 ` Daniel Barkalow
2005-05-10 0:44 ` Petr Baudis
2005-05-10 0:53 ` Daniel Barkalow
2005-05-10 5:45 ` Junio C Hamano
2005-05-10 6:25 ` Introducing GIT_DIR environment variable Junio C Hamano
2005-05-10 23:39 ` Alex Riesen
2005-05-10 2:16 ` [RFC] Renaming environment variables Junio C Hamano
2005-05-10 3:23 ` Daniel Barkalow
2005-05-10 0:25 ` Petr Baudis
2005-05-10 1:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3677.10.10.10.24.1115672678.squirrel@linux1 \
--to=seanlkml@sympatico.ca \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).