From: Jan Engelhardt <jengelh@inai.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http-backend: give a hint that web browser access is not supported
Date: Sun, 5 Dec 2021 11:13:32 +0100 (CET) [thread overview]
Message-ID: <34pqs81o-36p6-s416-s791-1onsqo1734oo@vanv.qr> (raw)
In-Reply-To: <xmqqtufnonor.fsf@gitster.g>
On Sunday 2021-12-05 02:17, Junio C Hamano wrote:
>>>What is in "pathinfo" parameter?
>> It is getenv("PATH_INFO").
>
>That part I know. The question was what would a typical value of
>that parameter look like in the context of somebody mistakenly
>visiting Git smart HTTP endpoint via their browser.
As far as I can tell, it contains the request URI plus index.html resolution;
https://git.inai.de/ reports /index.html while
https://git.inai.de/foo reports /foo (since foo does not exist in the fs).
>I am basically wondering if it is helping the user enough, or if it
>is sufficient to give just the "err" and "hint", and nothing else.
I felt that, because ls(1) reports the filename again, e.g.
$ ls x
ls: cannot access 'x': No such file or directory
that git-http-backend could do the same, especially since
pathinfo isn't just $ENV{REQUEST_URI} again at all times.
>> Yes, that seems more like it. I was not aware of send_strbuf.
>
>Heh, I wasn't either. The review of this topic was the first time I
>seriously read any part of that file, and I think I still only read
>just about 20% of it ;-)
>
>Also, will the real Git clients, which are the primary intended
>audiences this program is trying to talk to, be OK if we suddenly
>start giving a non-empty 404 page?
I am confident enough to say yes. It's not like git-http-backend
returned anything previously in the 404 case (like JSON or so),
therefore clients could not possibly depend on content.
>If any implementations of Git HTTP client this program is serving
>(1) uses a 404 response as a cue to decide its next request
>(e.g. there may be some "try this URL and if it fails, do another
>one" fallback logic)
Not sure if they heed Location: headers, but I am not changing
that :-)
next prev parent reply other threads:[~2021-12-05 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 0:39 [PATCH] http-backend: give a hint that web browser access is not supported Jan Engelhardt
2021-12-02 7:38 ` Junio C Hamano
2021-12-02 10:27 ` RFE: Split diff.noprefix for git-diff and git-format-patch (was: http-backend: give a hint that web browser access is not supported) Jan Engelhardt
2021-12-02 17:20 ` RFE: Split diff.noprefix for git-diff and git-format-patch Junio C Hamano
2021-12-02 10:28 ` [PATCH] http-backend: give a hint that web browser access is not supported Jan Engelhardt
2021-12-04 8:09 ` Junio C Hamano
2021-12-04 11:09 ` Jan Engelhardt
2021-12-05 1:17 ` Junio C Hamano
2021-12-05 10:13 ` Jan Engelhardt [this message]
2021-12-05 20:13 ` Junio C Hamano
2021-12-05 23:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34pqs81o-36p6-s416-s791-1onsqo1734oo@vanv.qr \
--to=jengelh@inai.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).