From: "firstname.lastname@example.org" <email@example.com>
To: "Junio C Hamano" <firstname.lastname@example.org>,
"Li Linchao via GitGitGadget" <email@example.com>
Cc: git <firstname.lastname@example.org>, "Derrick Stolee" <email@example.com>,
"Jonathan Tan" <firstname.lastname@example.org>
Subject: Re: Re: [PATCH v7] builtin/clone.c: add --reject-shallow option
Date: Fri, 26 Mar 2021 11:34:36 +0800 [thread overview]
Message-ID: <email@example.com> (raw)
>"Li Linchao via GitGitGadget" <firstname.lastname@example.org> writes:
>> This patch offers a new option '--reject-shallow' that can reject to
>> clone a shallow repository.
>> Signed-off-by: lilinchao <email@example.com>
>> Reviewed-by: Derrick Stolee <firstname.lastname@example.org>
>> Reviewed-by: Junio C Hamano<email@example.com>
>> Reviewed-by: Johannes Schindelin <firstname.lastname@example.org>
>> Reviewed-by: Jonathan Tan<email@example.com>
>The Reviewed-by trailer means something quite different from what
>you seem to think here. It is only given by the reviewers to the
>patch when they carefully reviewed and agrees what is in the patch.
>The patch authors are in no position to add it, unless they are
>explicitly told by reviewers that "this patch now can have my
>Reviewed-by:" or some equivalent.
>The (ideal) flow of events is
> 0. The author comes up with an idea and writes a patch.
> 1. The patch is sent to the list and Cc'ed to people who may be
> familiar with the area the patch touches. For second and
> subsequent iterations, those who gave review comments to the
> previous iterations are also good people to Cc to.
> 2. People give comments as reponses to the patch.
> (a) some may be happy with the iteration of the patch they
> reviewed, and may say "Thanks for contributing, this is now
> Reviewed-by: me". For second and subsequent iterations,
> they may say "This was improved relative to the previous
> iteration, and it still looks good and you have my
> (b) some may give constructive criticism, alternatives,
> enhancements, or outright "not a good idea, don't do this
> because ...".
> (c) some may just act as cheerleaders.
> 3. The author thinks about the review comments and also may find
> improvement him/herself.
> (a) There may need an update to the patch. If the patch has
> changed since the previous version in any way, ignore
> Reviewed-by: received in 2-(a). When a significant help was
> given to update the patch, you may add "Helped-by:" trailer
> to credit the person's contribution.
> Your own "Signed-off-by:" appears the last in the trailers
> (i.e. "this iteration of the patch was written with help
> from these people, and then I am signing it off just before
> sending it out").
> Go back to 1. and repeat as many times as it takes.
> (b) There may not be a need for any update to the patch. Only
> add the Reviewed-by: received in 2-(a) and otherwise do not
> change anything. Your own "Signed-off-by:" appears the last
> in the trailers. Send it to the list and to the maintainer
> 4. The maintainer applies the patch, unless there is no other
> comments received on that supposedly-the-final version sent in
> 3-(b), but a late review comment may make us realize that it was
> premature, in which case we may go back to 3-(a).
Many thanks for so detailed instructions about work flow in git community.
I will follow this flow tightly.
next prev parent reply other threads:[~2021-03-26 3:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 3:31 [PATCH] builtin/clone.c: add --no-shallow option Li Linchao via GitGitGadget
2021-02-04 5:50 ` Junio C Hamano
2021-02-04 10:32 ` lilinchao
2021-02-04 18:36 ` Junio C Hamano
2021-02-04 14:00 ` Johannes Schindelin
2021-02-04 18:24 ` Junio C Hamano
2021-02-08 8:31 ` [PATCH v2 0/2] " Li Linchao via GitGitGadget
2021-02-08 8:31 ` [PATCH v2 1/2] " lilinchao via GitGitGadget
2021-02-08 8:31 ` [PATCH v2 2/2] builtin/clone.c: add --reject-shallow option lilinchao via GitGitGadget
2021-02-08 13:33 ` [PATCH v2 0/2] builtin/clone.c: add --no-shallow option Derrick Stolee
[not found] ` <firstname.lastname@example.org>
2021-02-08 13:48 ` lilinchao
2021-02-08 14:12 ` [PATCH v3] builtin/clone.c: add --reject-shallow option Li Linchao via GitGitGadget
2021-02-09 20:32 ` Junio C Hamano
[not found] ` <email@example.com>
2021-02-10 9:07 ` lilinchao
2021-02-10 16:27 ` Junio C Hamano
[not found] ` <firstname.lastname@example.org>
2021-02-20 10:40 ` lilinchao
2021-02-21 7:05 ` [PATCH v4] " Li Linchao via GitGitGadget
2021-02-22 18:12 ` Junio C Hamano
2021-03-01 22:03 ` Jonathan Tan
2021-03-01 22:34 ` Junio C Hamano
2021-03-02 8:44 ` lilinchao
2021-03-03 23:59 ` Junio C Hamano
2021-03-04 1:53 ` Jonathan Tan
[not found] ` <email@example.com>
2021-02-28 17:58 ` lilinchao
2021-02-28 18:06 ` [PATCH v5] " Li Linchao via GitGitGadget
2021-03-01 7:11 ` lilinchao
2021-03-01 22:40 ` Johannes Schindelin
2021-03-04 6:26 ` lilinchao
2021-03-03 23:21 ` Junio C Hamano
2021-03-04 5:50 ` lilinchao
2021-03-04 17:19 ` [PATCH v6] " Li Linchao via GitGitGadget
2021-03-12 18:25 ` lilinchao
2021-03-25 11:09 ` [PATCH v7] " Li Linchao via GitGitGadget
2021-03-25 20:31 ` Junio C Hamano
2021-03-25 22:57 ` Junio C Hamano
[not found] ` <firstname.lastname@example.org>
2021-03-26 3:34 ` lilinchao [this message]
[not found] ` <email@example.com>
2021-03-26 3:49 ` lilinchao
2021-03-29 10:19 ` [PATCH v8] " Li Linchao via GitGitGadget
2021-03-29 21:36 ` Junio C Hamano
2021-03-30 9:54 ` Johannes Schindelin
2021-03-30 17:46 ` Junio C Hamano
2021-03-31 13:30 ` Johannes Schindelin
[not found] ` <firstname.lastname@example.org>
2021-03-31 11:03 ` lilinchao
2021-03-31 15:51 ` [PATCH v9] " lilinchao via GitGitGadget
2021-03-31 19:14 ` Junio C Hamano
2021-03-31 22:24 ` Johannes Schindelin
2021-03-31 22:37 ` Junio C Hamano
2021-04-01 10:46 ` [PATCH v10] " Li Linchao via GitGitGadget
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).