From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C4FE31F463 for ; Tue, 24 Sep 2019 09:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729718AbfIXJDr (ORCPT ); Tue, 24 Sep 2019 05:03:47 -0400 Received: from kylie.crudebyte.com ([5.189.157.229]:58185 "EHLO kylie.crudebyte.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729713AbfIXJDr (ORCPT ); Tue, 24 Sep 2019 05:03:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=nGck1Wtr524nplgwPVub0IVaYw0ulDwWIzroh0FHfjY=; b=HSq3lc2zEE3tbCetwyhSq7BN3J G0g7qkGhhy6Sa6HG2z+RX7sWb/OpMHE4+IwhnkWyRdr5iMgQo1VgD8geZnciyu4tV9/lyZ2bGWkXr BTiMb8Ke/7iqaGP7KhkECPNV8OXr2svFm91qExkmc8vpYbotbWqXH1JAWbJ5ppqr8OH8Xbt6F+Cca fm5W5TkmfSHhwekwoEZULDovr9EIF4Sq2dNEh1ArVuO1QEIMuHb+WCqbaAi8Osuz/AIzBm++wYusa H+Pg4m2A3G4Mvxj3EYFpii+O39I7FCoJLlMdkWG1RVU8tcjByOAgDvShZKZW3BbPORH92sXp0ybzO wXGrC2vCaxyDnMnf6OeMUu28KKW5AIuzM+Qrn41irQGpYt2DvkI0f9H0KXm0cOu8ksr8nDCdeV1fM AkzXudeQQg1d/K7nTp6bNL4K5bnt8IEzxIn0mDomD8oOsmr5sE/ZSstRF4tau1xF4ZOAEY5L86N3S 9lTtDUxkRlp4F4vtU8MBvbdQa2nvO1y8ZTqRJizGoPezcHiIvsvoZCR7ejQ16vZMPYTobxlWKBGR0 jmqohKbtzsP7UgtsDz4abmQWGIbEZRE+qO1K8inM013Seg8hZmgRzVIwQoDeEMKVoZi6sf3AjgQTh UkvrrKVK6tHEzqpyHx5xeGTp0Wgo285eqb/zBFOXw=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Jeff King , Christian Schoenebeck , berrange@redhat.com, stefanha@gmail.com, Greg Kurz , git@vger.kernel.org, antonios.motakis@huawei.com, dgilbert@redhat.com, Ian Kelling Subject: git format.from (was: 9p: Fix file ID collisions) Date: Tue, 24 Sep 2019 11:03:38 +0200 Message-ID: <3312839.Zbq2WQg2AT@silver> In-Reply-To: <20190923222415.GA22495@sigill.intra.peff.net> References: <56046367.TiUlWITyhT@silver> <20190923222415.GA22495@sigill.intra.peff.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Dienstag, 24. September 2019 00:24:15 CEST Jeff King wrote: > > On the other hand, considering the already existing --from argument and > > "format.from" config option: > > https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatfro > > m > > > > Wouldn't it make sense to just drop the currently existing sender != > > author > > string comparison in git and simply always add the "From:" line to the > > email's body if "format.from yes" is used, instead of introducing a > > suggested 2nd (e.g. "always-from") option? I mean sure automatically > > removing redundant information in the generated emails if sender == > > author sounds nice on first thought, but does it address anything useful > > in practice to justify introduction of a 2nd related option? > > Yes, the resulting mail would be correct, in the sense that it could be > applied just fine by git-am. But I think it would be uglier. IOW, I > consider the presence of the in-body From to be a clue that something > interesting is going on (like forwarding somebody else's patch). So from > my perspective, it would just be useless noise. Other communities may > have different opinions, though (I think I have seen some kernel folks > always including all of the possible in-body headers, including Date). > But it seems like it makes sense to keep both possibilities. Exactly, current git behaviour is solely "prettier" (at first thought only though), but does not address anything useful in real life. Current git behaviour does cause real life problems though: Many email lists are munging emails of patch senders whose domain is configured for requiring domain's emails being DKIM signed and/or being subject to SPF rules (a.k.a DMARC). So original sender's From: header is then automatically replaced by an alias (by e.g. mailman): https://en.wikipedia.org/wiki/DMARC#From:_rewriting For instance the email header: From: "Bob Bold" is automatically replaced by lists by something like From: "Bob Bold via Somelist" And since git currently always drops the From: line from the email's body if sender == author, as a consequence maintainers applying patches from such lists, always need to rewrite git history subsequently and have to replace patch author's identity manually for each commit to have their correct, real email address and real name in git history instead of something like "Bob Bold via Somelist" So what do you find "uglier"? I prefer key info not being lost as default behaviour. :-) Best regards, Christian Schoenebeck