git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH 0/1] Fix regression in t9902 with NO_PERL
@ 2018-12-13 13:01 Johannes Schindelin via GitGitGadget
  2018-12-13 13:01 ` [PATCH 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2018-12-13 13:01 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano

The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for
format-patch, 2018-11-03) changed also the way send-email options are
completed, by asking the git send-email command itself what options it
offers.

Necessarily, this must fail when built with NO_PERL because send-email 
itself is a Perl script. Which means that we need the PERL prerequisite for
the send-email test case in t9902.

Johannes Schindelin (1):
  t9902: 'send-email' test case requires PERL

 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/99
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] t9902: 'send-email' test case requires PERL
  2018-12-13 13:01 [PATCH 0/1] Fix regression in t9902 with NO_PERL Johannes Schindelin via GitGitGadget
@ 2018-12-13 13:01 ` Johannes Schindelin via GitGitGadget
  2018-12-13 13:27 ` [PATCH 0/1] Fix regression in t9902 with NO_PERL SZEDER Gábor
  2018-12-13 14:04 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
  2 siblings, 0 replies; 6+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2018-12-13 13:01 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Johannes Schindelin

From: Johannes Schindelin <johannes.schindelin@gmx.de>

With NO_PERL, the `git send-email` script errors out with code 128,
mentioning that Git was built without Perl support.

Therefore, when the completion tries to ask for possible completions via
`git send-email --git-completion-helper`, it won't provide what is
necessary for that test case to pass.

So let's mark it with the PERL prerequisite.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index d01ad8eb25..137fdc9bd5 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '
 	EOF
 '
 
-test_expect_success 'send-email' '
+test_expect_success PERL 'send-email' '
 	test_completion "git send-email --cov" "--cover-letter " &&
 	test_completion "git send-email ma" "master "
 '
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL
  2018-12-13 13:01 [PATCH 0/1] Fix regression in t9902 with NO_PERL Johannes Schindelin via GitGitGadget
  2018-12-13 13:01 ` [PATCH 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
@ 2018-12-13 13:27 ` SZEDER Gábor
  2018-12-13 13:52   ` Johannes Schindelin
  2018-12-13 14:04 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
  2 siblings, 1 reply; 6+ messages in thread
From: SZEDER Gábor @ 2018-12-13 13:27 UTC (permalink / raw)
  To: Johannes Schindelin via GitGitGadget; +Cc: git, Junio C Hamano

On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote:
> The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for
> format-patch, 2018-11-03) changed also the way send-email options are
> completed, by asking the git send-email command itself what options it
> offers.
> 
> Necessarily, this must fail when built with NO_PERL because send-email 
> itself is a Perl script. Which means that we need the PERL prerequisite for
> the send-email test case in t9902.

I find this text in the cover letter to be a better commit message
than the text in the patch itself, because mentions when it broke and
clearly mentions why it broke.

> Johannes Schindelin (1):
>   t9902: 'send-email' test case requires PERL
> 
>  t/t9902-completion.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
> Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/99
> -- 
> gitgitgadget

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL
  2018-12-13 13:27 ` [PATCH 0/1] Fix regression in t9902 with NO_PERL SZEDER Gábor
@ 2018-12-13 13:52   ` Johannes Schindelin
  0 siblings, 0 replies; 6+ messages in thread
From: Johannes Schindelin @ 2018-12-13 13:52 UTC (permalink / raw)
  To: SZEDER Gábor
  Cc: Johannes Schindelin via GitGitGadget, git, Junio C Hamano

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

Hi Gábor,

On Thu, 13 Dec 2018, SZEDER Gábor wrote:

> On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote:
> > The oneline notwithstanding,13374987dd (completion: use
> > _gitcompbuiltin for format-patch, 2018-11-03) changed also the way
> > send-email options are completed, by asking the git send-email command
> > itself what options it offers.
> > 
> > Necessarily, this must fail when built with NO_PERL because send-email
> > itself is a Perl script. Which means that we need the PERL
> > prerequisite for the send-email test case in t9902.
> 
> I find this text in the cover letter to be a better commit message than
> the text in the patch itself, because mentions when it broke and clearly
> mentions why it broke.

Okay, I replaced the commit message.

Ciao,
Dscho

> 
> > Johannes Schindelin (1):
> >   t9902: 'send-email' test case requires PERL
> > 
> >  t/t9902-completion.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
> > Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1
> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1
> > Pull-Request: https://github.com/gitgitgadget/git/pull/99
> > -- 
> > gitgitgadget
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 0/1] Fix regression in t9902 with NO_PERL
  2018-12-13 13:01 [PATCH 0/1] Fix regression in t9902 with NO_PERL Johannes Schindelin via GitGitGadget
  2018-12-13 13:01 ` [PATCH 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
  2018-12-13 13:27 ` [PATCH 0/1] Fix regression in t9902 with NO_PERL SZEDER Gábor
@ 2018-12-13 14:04 ` Johannes Schindelin via GitGitGadget
  2018-12-13 14:04   ` [PATCH v2 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
  2 siblings, 1 reply; 6+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2018-12-13 14:04 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano

The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for
format-patch, 2018-11-03) changed also the way send-email options are
completed, by asking the git send-email command itself what options it
offers.

Necessarily, this must fail when built with NO_PERL because send-email 
itself is a Perl script. Which means that we need the PERL prerequisite for
the send-email test case in t9902.

Changes since v1:

 * replaced the commit message by the cover letter, as it was deemed to be
   more informative.

Johannes Schindelin (1):
  t9902: 'send-email' test case requires PERL

 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/99

Range-diff vs v1:

 1:  32e6bf2dd3 ! 1:  8e3ddff2c7 t9902: 'send-email' test case requires PERL
     @@ -2,14 +2,14 @@
      
          t9902: 'send-email' test case requires PERL
      
     -    With NO_PERL, the `git send-email` script errors out with code 128,
     -    mentioning that Git was built without Perl support.
     +    The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin
     +    for format-patch, 2018-11-03) changed also the way send-email options
     +    are completed, by asking the git send-email command itself what options
     +    it offers.
      
     -    Therefore, when the completion tries to ask for possible completions via
     -    `git send-email --git-completion-helper`, it won't provide what is
     -    necessary for that test case to pass.
     -
     -    So let's mark it with the PERL prerequisite.
     +    Necessarily, this must fail when built with NO_PERL because send-email
     +    itself is a Perl script. Which means that we need the PERL prerequisite
     +    for the send-email test case in t9902.
      
          Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
      

-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/1] t9902: 'send-email' test case requires PERL
  2018-12-13 14:04 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
@ 2018-12-13 14:04   ` Johannes Schindelin via GitGitGadget
  0 siblings, 0 replies; 6+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2018-12-13 14:04 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Johannes Schindelin

From: Johannes Schindelin <johannes.schindelin@gmx.de>

The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin
for format-patch, 2018-11-03) changed also the way send-email options
are completed, by asking the git send-email command itself what options
it offers.

Necessarily, this must fail when built with NO_PERL because send-email
itself is a Perl script. Which means that we need the PERL prerequisite
for the send-email test case in t9902.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index d01ad8eb25..137fdc9bd5 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -1539,7 +1539,7 @@ test_expect_success 'complete tree filename with metacharacters' '
 	EOF
 '
 
-test_expect_success 'send-email' '
+test_expect_success PERL 'send-email' '
 	test_completion "git send-email --cov" "--cover-letter " &&
 	test_completion "git send-email ma" "master "
 '
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-12-13 14:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 13:01 [PATCH 0/1] Fix regression in t9902 with NO_PERL Johannes Schindelin via GitGitGadget
2018-12-13 13:01 ` [PATCH 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
2018-12-13 13:27 ` [PATCH 0/1] Fix regression in t9902 with NO_PERL SZEDER Gábor
2018-12-13 13:52   ` Johannes Schindelin
2018-12-13 14:04 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2018-12-13 14:04   ` [PATCH v2 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git