From: Derrick Stolee <stolee@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>, sbeller@google.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] commit-graph: add missing forward declaration
Date: Thu, 21 Jun 2018 20:17:37 -0400 [thread overview]
Message-ID: <316b6a43-a5d0-d10f-f995-94b3165ac325@gmail.com> (raw)
In-Reply-To: <20180621223942.81451-1-jonathantanmy@google.com>
On 6/21/2018 6:39 PM, Jonathan Tan wrote:
>> Both this and the previous patch look good to me;
>> you seem to have better (stricter) checking for
>> missing includes/forward declarations, am I missing
>> a compile option? (I have DEVELOPER=1 in config.mak)
> Thanks. No I don't - I discovered that these were missing as I was
> including these header files in other files.
I discovered similar missing headers in object-store.h while reworking
the MIDX patch series. Thanks for fixing them here!
next prev parent reply other threads:[~2018-06-22 0:17 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 21:29 [PATCH 0/5] Object store refactoring: commit graph Jonathan Tan
2018-06-21 21:29 ` [PATCH 1/5] object-store: add missing include Jonathan Tan
2018-06-21 21:29 ` [PATCH 2/5] commit-graph: add missing forward declaration Jonathan Tan
2018-06-21 21:43 ` Stefan Beller
2018-06-21 22:39 ` Jonathan Tan
2018-06-22 0:17 ` Derrick Stolee [this message]
2018-06-21 21:29 ` [PATCH 3/5] commit-graph: add free_commit_graph Jonathan Tan
2018-06-21 21:29 ` [PATCH 4/5] commit-graph: store graph in struct object_store Jonathan Tan
2018-06-25 20:57 ` Junio C Hamano
2018-06-25 22:09 ` Jonathan Tan
2018-06-26 16:40 ` Junio C Hamano
2018-06-21 21:29 ` [PATCH 5/5] commit-graph: add repo arg to graph readers Jonathan Tan
2018-06-21 22:41 ` Stefan Beller
2018-06-21 23:06 ` Jonathan Tan
2018-06-22 0:33 ` Derrick Stolee
2018-06-22 1:01 ` Derrick Stolee
2018-06-22 17:21 ` Jonathan Tan
2018-07-09 20:44 ` [PATCH v2 on ds/commit-graph-fsck 0/6] Object store refactoring: commit graph Jonathan Tan
2018-07-09 20:44 ` [PATCH v2 1/6] commit-graph: refactor preparing " Jonathan Tan
2018-07-09 21:41 ` Stefan Beller
2018-07-10 0:23 ` Derrick Stolee
2018-07-09 20:44 ` [PATCH v2 2/6] object-store: add missing include Jonathan Tan
2018-07-09 20:44 ` [PATCH v2 3/6] commit-graph: add missing forward declaration Jonathan Tan
2018-07-09 20:44 ` [PATCH v2 4/6] commit-graph: add free_commit_graph Jonathan Tan
2018-07-09 20:44 ` [PATCH v2 5/6] commit-graph: store graph in struct object_store Jonathan Tan
2018-07-09 20:44 ` [PATCH v2 6/6] commit-graph: add repo arg to graph readers Jonathan Tan
2018-07-10 0:48 ` Derrick Stolee
2018-07-10 17:31 ` Jonathan Tan
2018-07-11 19:41 ` Derrick Stolee
2018-07-11 21:08 ` Jonathan Tan
2018-07-10 11:53 ` SZEDER Gábor
2018-07-10 13:18 ` Johannes Schindelin
2018-07-10 17:23 ` Jonathan Tan
2018-07-09 21:47 ` [PATCH v2 on ds/commit-graph-fsck 0/6] Object store refactoring: commit graph Stefan Beller
2018-07-09 22:27 ` Junio C Hamano
2018-07-10 0:30 ` Derrick Stolee
2018-07-10 0:32 ` Derrick Stolee
2018-07-11 22:42 ` [PATCH v3 " Jonathan Tan
2018-07-11 22:42 ` [PATCH v3 1/6] commit-graph: refactor preparing " Jonathan Tan
2018-07-11 22:42 ` [PATCH v3 2/6] object-store: add missing include Jonathan Tan
2018-07-11 22:42 ` [PATCH v3 3/6] commit-graph: add missing forward declaration Jonathan Tan
2018-07-11 22:42 ` [PATCH v3 4/6] commit-graph: add free_commit_graph Jonathan Tan
2018-07-11 22:42 ` [PATCH v3 5/6] commit-graph: store graph in struct object_store Jonathan Tan
2018-07-11 22:42 ` [PATCH v3 6/6] commit-graph: add repo arg to graph readers Jonathan Tan
2018-08-13 0:30 ` [PATCH] t5318: avoid unnecessary command substitutions SZEDER Gábor
2018-08-13 11:23 ` Derrick Stolee
2018-08-13 19:05 ` Junio C Hamano
2018-07-12 16:56 ` [PATCH v3 0/6] Object store refactoring: commit graph Junio C Hamano
2018-07-12 17:43 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=316b6a43-a5d0-d10f-f995-94b3165ac325@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).