From: "Philip Oakley" <philipoakley@iee.org>
To: "Jeff King" <peff@peff.net>, "Роман Донченко" <dpb@corrigendum.ru>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jay Soffian" <jaysoffian@gmail.com>,
"Thomas Rast" <tr@thomasrast.ch>
Subject: Re: [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly
Date: Sun, 7 Dec 2014 17:48:05 -0000 [thread overview]
Message-ID: <316EF32F3157400882911A84EA0CFC61@PhilipOakley> (raw)
In-Reply-To: op.xqh5hrafnngjn5@freezie
From: "Роман Донченко" <dpb@corrigendum.ru>
> Jeff King <peff@peff.net> писал в своём письме Sun, 07 Dec 2014
> 12:18:59 +0300:
>
>> On Sat, Dec 06, 2014 at 10:36:23PM +0300, Роман Донченко wrote:
>>
>>> The RFC says that they are to be concatenated after decoding (i.e.
>>> the
>>> intervening whitespace is ignored).
>>
>> Thanks. Both patches look good to me, and I'd be happy to have them
>> applied as-is. I wrote a few comments below, but in all cases I think
>> I
>> convinced myself that what you wrote is best.
>
> I had the same concerns myself, and eventually convinced myself of the
> same. :-)
>
>> One final note on this bit of code: if there are multiple encoded
>> words,
>> we grab the $charset from the final encoded word, and never report
>> the
>> earlier charsets. Technically they do not all have to be the same
>> (rfc2047 even has an example where they are not). I think we can
>> dismiss
>> this, though, as:
>>
>> 1. It was like this before your patches (we might have seen
>> multiple
>> non-adjacent encoded words; you're just handling adjacent ones),
>> and nobody has complained.
>>
>> 2. Using two separate encodings in the same header is sufficiently
>> ridiculous that I can live with us not handling it properly.
>
> Yeah, that bugs me as well. But I think handling multiple encodings
> would require substantial reworking of the code, so I chickened out
> (with the same excuses :-)).
Would that be worth a terse comment in the documentation change part of
the patch?
"Multiple (RFC2047) encodings are not supported.",
or would that be bike shed noise.
Philip
next prev parent reply other threads:[~2014-12-07 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 19:36 [PATCH v2 1/2] send-email: align RFC 2047 decoding more closely with the spec Роман Донченко
2014-12-06 19:36 ` [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly Роман Донченко
2014-12-07 9:18 ` Jeff King
2014-12-07 14:35 ` Роман Донченко
2014-12-07 17:48 ` Philip Oakley [this message]
2014-12-07 18:17 ` Роман Донченко
2014-12-10 22:21 ` Philip Oakley
-- strict thread matches above, loose matches on Subject: below --
2014-12-14 15:59 [PATCH v2 1/2] send-email: align RFC 2047 decoding more closely with the spec Роман Донченко
2014-12-14 15:59 ` [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly Роман Донченко
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=316EF32F3157400882911A84EA0CFC61@PhilipOakley \
--to=philipoakley@iee.org \
--cc=avarab@gmail.com \
--cc=dpb@corrigendum.ru \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=peff@peff.net \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).