git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Git mailing list <git@vger.kernel.org>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: ["BUG"] builtin add-interactive does not honor 'color.diff. frag'
Date: Fri, 6 Nov 2020 11:31:32 -0500	[thread overview]
Message-ID: <313B8999-1E99-4695-A20D-E48840C30879@gmail.com> (raw)

Hi Johannes,

I tried the builtin add-interactive for the first time today, 
and noticed a very minor difference with the Perl version.
The title says it all.

Repro:

# Change the default color
$ git config color.diff.frag "magenta bold"
# Compare
$ git add -p
# and
$ git -c add.interactive.useBuiltin=true add -p 
# I'm on latest master
$ git --version
git version 2.29.2.154.g7f7ebe054a

Cheers,
Philippe.



             reply	other threads:[~2020-11-06 16:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 16:31 Philippe Blain [this message]
2020-11-06 17:03 ` ["BUG"] builtin add-interactive does not honor 'color.diff. frag' Jeff King
2020-11-10 16:06   ` Johannes Schindelin
2020-11-10 18:01     ` Jeff King
2020-11-10 18:28     ` [PATCH] add-interactive.c: use correct names to load color.diff.* config Jeff King
2020-11-10 19:17       ` Johannes Schindelin
2020-11-10 19:48         ` Jeff King
2020-11-10 22:30           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=313B8999-1E99-4695-A20D-E48840C30879@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).