From: Derrick Stolee <stolee@gmail.com>
To: "René Scharfe" <l.s.r@web.de>,
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: p2000 failure due to empty reflog
Date: Mon, 4 Oct 2021 15:55:41 -0400 [thread overview]
Message-ID: <30df5e39-3f2a-00d8-541b-347c43f36b38@gmail.com> (raw)
In-Reply-To: <b25ac1cc-8e77-17e6-602a-b289c1e1cfeb@web.de>
On 10/2/2021 1:37 PM, René Scharfe wrote:
> p2000 fails for me and reports:
>
> perf 18 - git checkout -f - (full-v3):
> running:
> (
> cd full-v3 &&
> echo >>f2/f4/a &&
> git checkout -f -
> )
>
> error: pathspec '-' did not match any file(s) known to git
>
> checkout fails because the reflog is empty, so the "-" can't be
> resolved. The pathspec error message is confusing, though.
>
> The patch below adds a reflog entry and allows the script to
> succeed.
>
> Before the "test_perf_on_all git commit -a -m A", there are two
> reflog entries in each of the five clones, after it there are
> none. How is that even possible?
That is certainly confusing. Is there something about your global
(or local to your test repo) GC settings that cause an auto-GC to
prune the reflog aggressively?
> @@ -109,6 +110,14 @@ test_perf_on_all git status
> test_perf_on_all git add -A
> test_perf_on_all git add .
> test_perf_on_all git commit -a -m A
> +
> +test_expect_success 'add reflog entry' '
> + for repo in full-v3 full-v4 sparse-v3 sparse-v4
> + do
> + git -C $repo checkout $OLD_COMMIT
> + done
> +'
> +
> test_perf_on_all git checkout -f -
While I believe this will fix the situation, it might only be
a band-aid on the real problem of losing the reflog during the
test.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-10-04 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 17:37 p2000 failure due to empty reflog René Scharfe
2021-10-04 19:55 ` Derrick Stolee [this message]
2021-10-05 20:28 ` René Scharfe
2021-10-06 16:59 ` Junio C Hamano
2021-10-09 14:39 ` [PATCH] perf: disable automatic housekeeping René Scharfe
2021-10-09 14:57 ` "git reflog expire" blindly trusting timestamps in reflogs Ævar Arnfjörð Bjarmason
2021-10-09 17:50 ` Junio C Hamano
2021-10-11 16:32 ` Jeff King
2021-10-05 21:38 ` p2000 failure due to empty reflog Ævar Arnfjörð Bjarmason
2021-10-09 14:39 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30df5e39-3f2a-00d8-541b-347c43f36b38@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).