From: Maxim Belsky <public.belsky@gmail.com>
To: Durant Schoon <durant.schoon@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion (zsh): fix misleading install location
Date: Wed, 2 Oct 2019 00:05:26 +0300 [thread overview]
Message-ID: <30798B33-EF82-449F-BDF3-B639A292BCFA@gmail.com> (raw)
In-Reply-To: <0102016b2ebafc26-1bd39076-62e4-4b7e-9309-b08cc072fbdf-000000@eu-west-1.amazonses.com>
Hey,
I face same issue a few days ago. Initially I thought `~/.zsh/_git` should be a dictionary. I’ve made all required actions, but completion didn't work. After a few hours I found that it should be just a file instead of a dictionary.
I have two ideas how to patch this comments to help another users setup completion:
1. Add a note that `~/.zsh/_git` should be a file https://github.com/mbelsky/git/commit/e951a0dee5f124ad755d32fa5cc5cded471d389b
2. Change the patch to make it more obvious https://github.com/mbelsky/git/commit/6c839727163b29b2d2cf5d2ec7f780c2826848d6
It’s my first time mail listing experience so I just put links on github to don’t make something wrong.
What do you think about this changes?
> On 7 Jun 2019, at 00:38, Durant Schoon <durant.schoon@gmail.com> wrote:
>
> diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
> index 886bf95d1f594..0e63004e2613e 100644
> --- a/contrib/completion/git-completion.zsh
> +++ b/contrib/completion/git-completion.zsh
> @@ -11,8 +11,8 @@
> #
> # zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh
> #
> -# The recommended way to install this script is to copy to '~/.zsh/_git', and
> -# then add the following to your ~/.zshrc file:
> +# The recommended way to install this script is to copy to '~/.zsh/_git/',
> +# and then add the following to your ~/.zshrc file:
prev parent reply other threads:[~2019-10-01 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 21:38 [PATCH] completion (zsh): fix misleading install location Durant Schoon
2019-06-06 22:44 ` Denton Liu
2019-06-06 22:52 ` Felipe Contreras
2019-09-24 20:51 ` Durant Schoon
2019-10-01 21:05 ` Maxim Belsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30798B33-EF82-449F-BDF3-B639A292BCFA@gmail.com \
--to=public.belsky@gmail.com \
--cc=durant.schoon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).